After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674948 - small code clean-ups for the keyboard plugin
small code clean-ups for the keyboard plugin
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks: 676102
 
 
Reported: 2012-04-27 12:48 UTC by Rui Matos
Modified: 2012-05-17 17:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Remove needless call to XkbUseExtension (1.00 KB, patch)
2012-04-27 12:48 UTC, Rui Matos 		committed Details | Review
keyboard: Fix XkbSelectEventDetails event_type argument (1.07 KB, patch)
2012-04-27 12:48 UTC, Rui Matos 		committed Details | Review
keyboard: Remove a needless GObject constructor override (1.71 KB, patch)
2012-04-27 12:48 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2012-04-27 12:48:34 UTC 
Patches attached.
Comment 1 Rui Matos 2012-04-27 12:48:36 UTC 
Created attachment 212956 [details] [review]
keyboard: Remove needless call to XkbUseExtension

XkbQueryExtension does everything we need here.
Comment 2 Rui Matos 2012-04-27 12:48:39 UTC 
Created attachment 212957 [details] [review]
keyboard: Fix XkbSelectEventDetails event_type argument

This just happened to work by chance since both XkbStateNotify and
XkbStateNotifyMask are the same integral value.
Comment 3 Rui Matos 2012-04-27 12:48:42 UTC 
Created attachment 212958 [details] [review]
keyboard: Remove a needless GObject constructor override
Comment 4 Bastien Nocera 2012-05-15 15:17:38 UTC 
Review of attachment 212956 [details] [review]:

Fine.
Comment 5 Bastien Nocera 2012-05-15 15:47:06 UTC 
Review of attachment 212957 [details] [review]:

Looks good.
Comment 6 Bastien Nocera 2012-05-15 15:47:48 UTC 
Review of attachment 212958 [details] [review]:

Looks good.
Comment 7 Bastien Nocera 2012-05-17 17:15:10 UTC 
Attachment 212956 [details] pushed as eeff2b0 - keyboard: Remove needless call to XkbUseExtension
Attachment 212957 [details] pushed as 718a07d - keyboard: Fix XkbSelectEventDetails event_type argument
Attachment 212958 [details] pushed as f808719 - keyboard: Remove a needless GObject constructor override