After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674611 - Remove gconf.path once EDS drops GConf
Remove gconf.path once EDS drops GConf
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal minor
: Unset
Assigned To: Jeremy Whiting
folks-maint
Depends on: 635379 675121
Blocks:
 
 
Reported: 2012-04-23 09:47 UTC by Philip Withnall
Modified: 2012-07-13 21:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove gconf from unit tests. (6.80 KB, patch)
2012-07-10 20:51 UTC, Jeremy Whiting 		reviewed Details | Review

Description Philip Withnall 2012-04-23 09:47:56 UTC 
Once EDS drops its GConf dependency (bug #635379), we can get rid of gconf.path and all the gubbins we’re using to encapsulate GConf usage when running our unit tests.

(Note that folks no longer has a hard dependency on GConf, so this bug doesn’t block the desktop-wide migration to GSettings. See also: bug #647909.)
Comment 1 Jeremy Whiting 2012-07-10 20:51:24 UTC 
Created attachment 218478 [details] [review]
Remove gconf from unit tests.

This patch removes gconf.path and removes the GCONF environment variables from the unit test environments.  

EDS unit tests are currently failing with this patch and on master, so may need to wait to merge this until master unit tests are no longer failing to be sure this isn't breaking something.
Comment 2 Philip Withnall 2012-07-11 19:22:39 UTC 
Review of attachment 218478 [details] [review]:

Aren’t you missing the “--pkg gconf-2.0” in folks/Makefile.am?

Apart from that, it looks good to commit once the EDS tests are fixed on master.
Comment 3 Jeremy Whiting 2012-07-13 21:26:48 UTC 
Merged patch with "--pkg gconf-2.0" taken out of folks/Makefile.am also on master branch.