After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674577 - Non static variable in GtkStyleProviderPrivate
Non static variable in GtkStyleProviderPrivate
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkStyleContext
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-04-22 17:27 UTC by Giovanni Campagna
Modified: 2012-04-23 17:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
StyleProviderPrivate: mark internal variable as static (987 bytes, patch)
2012-04-22 17:28 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-04-22 17:27:31 UTC 
See patch.
Found because it was shadowed by gnome-bluetooth, and luckily only resulted in a warning in gnome-shell.
Comment 1 Giovanni Campagna 2012-04-22 17:28:19 UTC 
Created attachment 212552 [details] [review]
StyleProviderPrivate: mark internal variable as static

Otherwise, it could conflict with other symbols with the same
name exported by a different shared library, with undefined
effects.
Comment 2 Matthias Clasen 2012-04-23 02:57:57 UTC 
Review of attachment 212552 [details] [review]:

thanks, good catch
Comment 3 Giovanni Campagna 2012-04-23 17:51:49 UTC 
Attachment 212552 [details] pushed as dee341f - StyleProviderPrivate: mark internal variable as static