After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674529 - Replace the menu bar with an app menu
Replace the menu bar with an app menu
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-21 15:44 UTC by Allan Day
Modified: 2012-09-13 03:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Port to GtkApplication (6.59 KB, patch)
2012-04-25 23:11 UTC, Florian Müllner
committed Details | Review
window: Replace menu bar with app menu (13.95 KB, patch)
2012-04-25 23:13 UTC, Florian Müllner
committed Details | Review

Description Allan Day 2012-04-21 15:44:25 UTC
An app menu will make the calculator consistent with other GNOME 3 apps. It will also make it easier to use (yay for fewer disclosure points) and make it look nicer.

Suggested format for the app menu:

Mode:
o Basic
  Advanced
  Financial
  Programming
---
Preferences
---
Help
About Calculator
Quit
Comment 1 Florian Müllner 2012-04-25 23:11:00 UTC
Created attachment 212835 [details] [review]
Port to GtkApplication
Comment 2 Florian Müllner 2012-04-25 23:13:20 UTC
Created attachment 212836 [details] [review]
window: Replace menu bar with app menu
Comment 3 Robert Ancell 2012-04-27 03:26:36 UTC
Review of attachment 212835 [details] [review]:

Works great, committed.
Comment 4 Robert Ancell 2012-04-27 03:26:42 UTC
Review of attachment 212836 [details] [review]:

Thanks Florian!
Comment 5 Robert Ancell 2012-04-27 03:27:05 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 6 Sebastien Bacher 2012-06-13 10:36:17 UTC
Could we keep a normal menu layout when application menus are not supported? 

Other applications have been doing that, see i.e:
https://bugzilla.gnome.org/show_bug.cgi?id=674952#c9
or 
http://git.gnome.org/browse/nautilus/commit/?id=ddd36b7f3a159a57c2284a980b31a111ebb16a3b

Having one flat menu (which is the gtk builtin fallback) is just a poor design and quite a regression for non gnome-shell users (if you still care about other platform or other linux desktops)
Comment 7 Jürg Billeter 2012-09-11 19:30:17 UTC
Another regression: bug 683823
Comment 8 Robert Ancell 2012-09-13 03:42:16 UTC
Seb - no, GCalctool never had enough menu elements for more than one menu so the fallback is appropriate. It's worse design to spread the few menu items across a menubar. Agreed it looks a bit messy if a shell doesn't have a better method of rendering a menu but the menus always looked bad anyway.