GNOME Bugzilla – Bug 674405
i can has full-screen mode?
Last modified: 2013-08-01 16:18:47 UTC
I've recently been forced to use System Monitor on a 1366 x 768 display and it's no fun. GNOME Shell and System Monitor's title, menu, tab and status bars take too many vertical pixels and the graphs appear all squashed. Can we please add a full-screen mode to System Monitor?
Could you please attach a screenshot of how system monitor looks on your screen?
Created attachment 219635 [details] System Monitor at 1366 x 768 resolution.
After the port to App menu has landed, we could think of replace the tab labels with buttons in a toolbar (see e.g the mockup https://github.com/gnome-design-team/gnome-mockups/blob/master/usage/usage-wireframes.png), and then set hide_titlebar_when_maximized = TRUE.
Usage will be a separate application, as far as I know, as it's targeted for novice users/daily use, while system monitor is/will remain an advanced tool for advanced tasks not achievable from Usage, and others. Nevertheless, I like the hide_titlebar_when_maximized idea.
By the way, is there a gtk widget for viewbuttons like the ones on the screenshot?
(In reply to comment #4) > Usage will be a separate application, as far as I know, as it's targeted for > novice users/daily use, while system monitor is/will remain an advanced tool > for advanced tasks not achievable from Usage, and others. Nevertheless, I like > the hide_titlebar_when_maximized idea. Yes, sure, I was just thinking of using some of the new GNOME3 patterns in System Monitor. If you like the idea I can prepare a patch for this. The button box in the mockup can be done with GtkRadioButtons properly styled, for example. But before, could you consider also bug 684536 ? I think that some cleanup could be useful at this point
> Yes, sure, I was just thinking of using some of the new GNOME3 patterns in > System Monitor. If you like the idea I can prepare a patch for this. The button > box in the mockup can be done with GtkRadioButtons properly styled, for > example. Patches are welcome, that would be great! > But before, could you consider also bug 684536 ? I think that some > cleanup could be useful at this point That's done already, thanks for the patch.
Created attachment 239236 [details] [review] Add libgd
Created attachment 239237 [details] [review] Switch to GdStack and GtkHeaderBar
Review of attachment 239236 [details] [review]: Strange thing: the patch adds the 0 sized libgd directory, but make complained about the directory libgd not existing, until I have removed the libgd file and added the submodule again with git submodule add. Is this normal? Can this be automated somehow?
(In reply to comment #10) > Review of attachment 239236 [details] [review]: > > Strange thing: the patch adds the 0 sized libgd directory, but make complained > about the directory libgd not existing, until I have removed the libgd file and > added the submodule again with git submodule add. Is this normal? Can this be > automated somehow? No I don't think it's normal :) Maybe you applied the patch with "git apply"? It fails for submodules, the correct command is "git am" witch actually commits the submodule
(In reply to comment #11) > (In reply to comment #10) > > Review of attachment 239236 [details] [review] [details]: > > > > Strange thing: the patch adds the 0 sized libgd directory, but make complained > > about the directory libgd not existing, until I have removed the libgd file and > > added the submodule again with git submodule add. Is this normal? Can this be > > automated somehow? > > No I don't think it's normal :) > Maybe you applied the patch with "git apply"? It fails for submodules, the > correct command is "git am" witch actually commits the submodule No, I have applied the patch with patch -p1<.... I have never heard of git am until now, but I will try that when I get home.
libgd submodule is no longer needed. GtkStack and GtkStackSwitcher are available since gtk+ 3.9.0 (It would be great to have this on 3.10. Thank you for working on this.)
@Stefano Facchini: Could you please help me out in updating this patch? I have started manually applying it (as it didn't apply to any of the files) but I can't get properly migrate it as the GAction porting and this patch are totally incompatible.
(In reply to comment #14) > @Stefano Facchini: Could you please help me out in updating this patch? I have > started manually applying it (as it didn't apply to any of the files) but I > can't get properly migrate it as the GAction porting and this patch are totally > incompatible. Yes updating this patch was in the TODO list :), but if you agree, I'd just prefer to look for some more possible cleanup before actully adding new code, it seems to me that the interface code could be reworked and disentangled a bit, for instance moving each callback where it belongs to instead of keeping them all mixed up in a single callback.cpp...
(In reply to comment #15) > Yes updating this patch was in the TODO list :), but if you agree, I'd just > prefer to look for some more possible cleanup before actully adding new code, > it seems to me that the interface code could be reworked and disentangled a > bit, for instance moving each callback where it belongs to instead of keeping > them all mixed up in a single callback.cpp... Agreed on the callbacks stuff, I have been thinking of tying as much as possible to gsettings bindings.
Created attachment 250116 [details] [review] Port to GtkStack and GtkHeaderBar Updated patch. There's a problem with the resources page (black graph background), but since I saw you have on going work in the ubergraph branch I didn't even try to touch loadgraphs.cpp.
Created attachment 250117 [details] [review] Move Refresh and View buttons in the headerbar Now that we have a headerbar we can put our buttons there
Created attachment 250118 [details] [review] Move End Process button in the headerbar
Created attachment 250143 [details] [review] Move End Process button in the headerbar Rebased.
Review of attachment 250117 [details] [review]: Pushed.
Review of attachment 250116 [details] [review]: Pushed.
Review of attachment 250143 [details] [review]: Pushed.
As the tabs have been converted into stackswitcher, the buttons are all in the same row with the stackswitcher buttons, and the titlebar is hidden when maximized, I am marking this as fixed. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.