After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674393 - [mpegtsdemux] Memory leaks
[mpegtsdemux] Memory leaks
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-19 13:43 UTC by Gil Pedersen
Modified: 2012-04-20 08:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
memory leaks fix patch (3.54 KB, patch)
2012-04-19 13:43 UTC, Gil Pedersen 		needs-work Details | Review

Description Gil Pedersen 2012-04-19 13:43:35 UTC 
Created attachment 212360 [details] [review]
memory leaks fix patch

A lot of objects are leaking from the various mpegtsdemux modules. Attached patch will fix those that I discovered.

The patch should apply against both master and 0.10.
Comment 1 Sebastian Dröge (slomo) 2012-04-19 13:48:01 UTC 
Review of attachment 212360 [details] [review]:

::: gst/mpegtsdemux/mpegtsparse.c
@@ +253,3 @@
   }
+
+  gst_event_unref (event);

This looks wrong, gst_pad_push_event() a few lines above steals the reference
Comment 2 Gil Pedersen 2012-04-19 14:03:53 UTC 
Review of attachment 212360 [details] [review]:

::: gst/mpegtsdemux/mpegtsparse.c
@@ +253,3 @@
   }
+
+  gst_event_unref (event);

It is correct. The line before is:
gst_event_ref (event);
Comment 3 Wim Taymans 2012-04-20 08:51:46 UTC 
commit f0632569066e680ef5fb6bf8083f49deacce8565
Author: Gil Pedersen <git@gpost.dk>
Date:   Thu Apr 19 13:59:37 2012 +0200

    mpegtsdemux: fix memory leaks
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=674393