After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674243 - rtmp: fix build on windows, link against winsock library
rtmp: fix build on windows, link against winsock library
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-17 09:53 UTC by LRN
Modified: 2012-05-05 18:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add necessary LIBS to the linker (1.55 KB, patch)
2012-04-17 09:54 UTC, LRN 		committed Details | Review

Description LRN 2012-04-17 09:53:33 UTC 
rtmp requires libws2_32 and libwinmm when compiled on W32
Comment 1 LRN 2012-04-17 09:54:10 UTC 
Created attachment 212190 [details] [review]
Add necessary LIBS to the linker
Comment 2 LRN 2012-04-17 09:54:35 UTC 
The patch is kinda crude.
Comment 3 Tim-Philipp Müller 2012-05-05 15:29:00 UTC 
Removed libwinmm, since only libws2_32 should be needed (and even that should really be done inside librtmp).

Use RTMP_LIBS directly, as for other plugins. For consistency, not because it's the best thing to do.

Fixed typo in GSTRTMP_LIBS="$GSTTRMP_LIBS ..

Thanks for the patch!


commit e4ec3e4bd70c4dabdeb7883101cd14ee43ec5e17
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Tue Apr 17 11:44:18 2012 +0400

    rtmp: link to winsock library on Windows
    
    https://bugzilla.gnome.org/show_bug.cgi?id=674243
Comment 4 Tim-Philipp Müller 2012-05-05 18:22:02 UTC 
Let's try this again:

 commit b87f7345db2c998e37eae350ad880a2bb0d0f4cd
 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
 Date:   Sat May 5 18:20:33 2012 +0100

    Add WINSOCK2_LIBS, remove WIN32_LIBS, fix rtmp build on Windows some more
    
    One way of passing -lws2_32 to plugins should be enough..