The tp-glib branch has been merged. We still have to wait for a release and bump the dep but it can already be reviewed.

http://cgit.collabora.com/git/user/cassidy/empathy/log/?h=debug-674182

Created attachment 212258 [details] [review]
debug_window_dispose: use g_clear_object()

Created attachment 212259 [details] [review]
empathy-debugger: use self->priv pattern

Created attachment 212260 [details] [review]
debug-window: use TpDebugClient

Created attachment 212261 [details] [review]
merge store_filter_foreach () and copy_model_foreach ()

They were basically the same function. The only difference was that one was
assuming to receive an empty string during the first iteration while the other
was coping with it being NULL.

Created attachment 212262 [details] [review]
Store the TpDebugMessage in the model

Makes things easier and saves us from dupping the info.

Created attachment 212263 [details] [review]
Stop generating Debug API

Review of attachment 212260 [details] [review]:

::: src/empathy-debug-window.c
@@ +245,3 @@
+
+  t = tp_debug_message_get_time (msg);
+  /* FIME: we loose the microseconds */

FIXME

@@ +246,3 @@
+  t = tp_debug_message_get_time (msg);
+  /* FIME: we loose the microseconds */
+  timestamp = (gdouble) g_date_time_to_unix (t);

why gdouble any not gint64 ?

Bah actually comment #8 is fixed by the commit just after... so +1 for all :)

Attachment 212258 [details] pushed as 77e0eed - debug_window_dispose: use g_clear_object()
Attachment 212259 [details] pushed as cad7698 - empathy-debugger: use self->priv pattern
Attachment 212260 [details] pushed as bb58c64 - debug-window: use TpDebugClient
Attachment 212261 [details] pushed as 60e7f9f - merge store_filter_foreach () and copy_model_foreach ()
Attachment 212262 [details] pushed as 08ab2c8 - Store the TpDebugMessage in the model
Attachment 212263 [details] pushed as a9e5357 - Stop generating Debug API