After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673891 - vp8dec: add threads option
vp8dec: add threads option
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-11 08:50 UTC by Oleksij Rempel
Modified: 2012-09-24 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch v1 (3.74 KB, patch)
2012-04-11 08:50 UTC, Oleksij Rempel
none Details | Review
patch v2 (4.63 KB, patch)
2012-04-11 13:52 UTC, Oleksij Rempel
rejected Details | Review

Description Oleksij Rempel 2012-04-11 08:50:05 UTC
Created attachment 211812 [details] [review]
patch v1

vp8 decoder can use threaded decoding, if stream was created with option token-parts >= 1,
Comment 1 Oleksij Rempel 2012-04-11 10:51:47 UTC
Here are test results made on Intel Core2 Duo E8400 @ 3.00GHz.
The video length is 02:05:02 with resolution 720x428@25fps

pipe line:
time gst-launch-1.0 filesrc location=in_den_schuen_meiner_schwester.mkv ! matroskademux ! vp8dec threads=2 ! fakesink

with threads=1:
real	15m7.971s
user	14m18.613s
sys	0m9.595s

with threads=2:
real	11m59.063s
user	13m10.811s
sys	1m11.575s
Comment 2 Oleksij Rempel 2012-04-11 13:52:46 UTC
Created attachment 211827 [details] [review]
patch v2

new patch, changes:
- rename options threads to max-threads. It describe better what it actually do.
- set default count of threads to 8. This is limit used by decoder. Decoder will decide haw many threads to create. It checks number of cores and number of token parts. We can't do better decision than decoder. If, for some reason, user need to limit number of threads, he can use this option.
Comment 3 Sebastian Dröge (slomo) 2012-09-16 08:39:21 UTC
This is fixed in 0.11 now, while reworking all the decoder and encoder properties.