After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673850 - Cannot see selection in file open dialog
Cannot see selection in file open dialog
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-04-10 16:44 UTC by Stef Walter
Modified: 2016-03-31 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of the problem (324.93 KB, image/png)
2012-04-10 16:45 UTC, Stef Walter
  Details
non working css to the left, working css to the right (to understand what I'm talking about) (124.16 KB, image/png)
2012-06-22 14:01 UTC, Christophe Fergeau
  Details
Fix not showing selection in file selector (2.09 KB, patch)
2012-06-28 15:19 UTC, Alexander Larsson
committed Details | Review

Description Stef Walter 2012-04-10 16:44:26 UTC
Cannot see the file selection in the 'file open dialog'. See attached screenshot.

In addition the file open dialog is not transient for (or tied to) its parent window, despite behaving modally.
Comment 1 Stef Walter 2012-04-10 16:45:18 UTC
Created attachment 211777 [details]
Screenshot of the problem
Comment 2 Marc-Andre Lureau 2012-04-10 17:04:46 UTC
You mean the currently selected item in the file list is not highlighted?

Isn't that a gtk+ or style bug?
Comment 3 Christophe Fergeau 2012-04-10 18:48:27 UTC
Yes to first question, I've been seeing this too. Totem doesn't have this issue
Comment 4 Alexander Larsson 2012-06-21 19:01:11 UTC
Could be something in our custom CSS, but i don't see anything suspicious.
Comment 5 Stef Walter 2012-06-22 05:47:22 UTC
Can no longer duplicate with:

Installed Packages
Name        : gnome-boxes
Arch        : x86_64
Version     : 3.4.3
Release     : 1.fc17
Comment 6 Zeeshan Ali 2012-06-22 13:39:40 UTC
Thanks Stef for reporting and then verifying!
Comment 7 Christophe Fergeau 2012-06-22 13:49:39 UTC
There's a bug in gnome-boxes 3.4.3 causing the css not to be loaded and the media list to look ugly:
(gnome-boxes:32521): Boxes-WARNING **: main.vala:88: gtk-style.css:105:18: Horizontal and vertical offsets are required
Once you remove lines 105 and 106 from this file, boxes is back to its usual looks, and the selection in the file open dialog is broken.
This is reproducible with git master as well.
Comment 8 Christophe Fergeau 2012-06-22 14:01:32 UTC
Created attachment 217028 [details]
non working css to the left, working css to the right (to understand what I'm talking about)

This 'bad look' has been verified on a non development fedora box, and the file chooser selection is missing there
Comment 9 Zeeshan Ali 2012-06-22 14:04:28 UTC
(In reply to comment #8)
> Created an attachment (id=217028) [details]
> non working css to the left, working css to the right (to understand what I'm
> talking about)
> 
> This 'bad look' has been verified on a non development fedora box, and the file
> chooser selection is missing there

That seems to be a  different bug. Why reopen this one?
Comment 10 Christophe Fergeau 2012-06-22 14:09:03 UTC
(In reply to comment #9)
> (In reply to comment #8)
> > Created an attachment (id=217028) [details] [details]
> > non working css to the left, working css to the right (to understand what I'm
> > talking about)
> > 
> > This 'bad look' has been verified on a non development fedora box, and the file
> > chooser selection is missing there
> 
> That seems to be a  different bug. Why reopen this one?

Because this bug is about "cannot see selection in file open dialog" and this bug would still happen in the 3.4.3 f17 package if there was not this other bug, and this still happens in git master as well?
Comment 11 Zeeshan Ali 2012-06-22 14:14:16 UTC
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > Created an attachment (id=217028) [details] [details] [details]
> > > non working css to the left, working css to the right (to understand what I'm
> > > talking about)
> > > 
> > > This 'bad look' has been verified on a non development fedora box, and the file
> > > chooser selection is missing there
> > 
> > That seems to be a  different bug. Why reopen this one?
> 
> Because this bug is about "cannot see selection in file open dialog" and this
> bug would still happen in the 3.4.3 f17 package

I'm now even more confused. Stef reported that he can't reproduce the issue in exactly that version/package and you are saying that its still reproducible.
Comment 12 Christophe Fergeau 2012-06-22 14:16:15 UTC
The 3.4.3 package has a bug, at least on the machines I've tested it on, which hides this fileselection bug.
We'll need confirmation from Stef if he hits the issue I've described, which is why I've attached a good/bad screenshot.
Comment 13 Christophe Fergeau 2012-06-26 13:40:09 UTC
This is caused by "background-color: transparent;" in

.view,
GtkClutterOffscreen,
.boxes-bg {
    background-color: transparent;
    background-image: none;
}

I'm CSS-illiterate so no idea what a fix would be
Comment 14 Marc-Andre Lureau 2012-06-26 14:33:08 UTC
(In reply to comment #13)
> This is caused by "background-color: transparent;" in
> 
> .view,
> GtkClutterOffscreen,
> .boxes-bg {
>     background-color: transparent;
>     background-image: none;
> }
> 
> I'm CSS-illiterate so no idea what a fix would be

good time to learn some bits :)

afaik, .view is the class used for list/tree view, so we need to check what really need this, you can try removing .view line perhaps and see :)
Comment 15 Christophe Fergeau 2012-06-26 14:46:41 UTC
(In reply to comment #14)

> afaik, .view is the class used for list/tree view, so we need to check what
> really need this, you can try removing .view line perhaps and see :)

Yep, this helps too.
Comment 16 Alexander Larsson 2012-06-28 10:09:38 UTC
Yeah, using something as wide as ".view" here seems pretty risky anyway. We should remove that, and if there is some problem with that we should add a more detailed rule to only fix that problem.
Comment 17 Alexander Larsson 2012-06-28 15:19:01 UTC
Created attachment 217535 [details] [review]
Fix not showing selection in file selector

We were using a way-to-broad CSS selector like ".view" which
also affected the file selector. Remove this and instead apply
the (already also matched) boxes-bg style class on the .view
places that needed to match.
Comment 18 Alexander Larsson 2012-06-28 17:05:03 UTC
Attachment 217535 [details] pushed as e5eccfa - Fix not showing selection in file selector