After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673742 - Add keywords support for Totem
Add keywords support for Totem
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-04-08 15:09 UTC by Nekhelesh
Modified: 2012-04-11 17:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to add keywords (678 bytes, patch)
2012-04-08 15:09 UTC, Nekhelesh 		needs-work Details | Review

Description Nekhelesh 2012-04-08 15:09:48 UTC 
Created attachment 211586 [details] [review]
Patch to add keywords

The desktop file needs to updated with the keywords specifications thereby supporting the new XDG convention. I have also added the patch that needs to be applied. This patch adds the keywords Audio and Video to improve the search terms to find totem easily.
Comment 1 Bastien Nocera 2012-04-10 09:47:44 UTC 
Review of attachment 211586 [details] [review]:

Audio isn't a keyword I'd want to associate with Totem. Got any more keywords to add?
Comment 2 Bastien Nocera 2012-04-11 12:08:19 UTC 
commit b730b1faf830900e58718503aff8b55f0aaddacb
Author: Bastien Nocera <hadess@hadess.net>
Date:   Wed Apr 11 13:07:08 2012 +0100

    data: Add keywords
    
    As used in gnome-shell nowadays.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=673742
Comment 3 Nekhelesh 2012-04-11 16:54:33 UTC 
Bastien, how about the following keywords,

1. DVD,VCD,Shoutcast.. These are some of the functions performed by totem as stated in http://projects.gnome.org/totem/. So users looking for a shoutcast player will see totem displayed in their searches.

2. The reason that I also included Audio is because totem has playlist support meaning users can stack songs and also use it as a music player if they wish since totem also provides options to has repeat and shuffle mode.
Comment 4 Bastien Nocera 2012-04-11 17:00:57 UTC 
VCD support is bad, so I wouldn't advertise it. DVD was already added. Shoutcast and Audio aren't things I want to advertise Totem as doing. If people use it for that, fine, but I'm guessing they might be disappointed in the future.
Comment 5 Nekhelesh 2012-04-11 17:18:02 UTC 
True, besides there are already plans for a new music player by gnome. In that case, yup this bug is resolved with the required keywords.