After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673270 - e-web-app-utils: warn when cookies are unavailable
e-web-app-utils: warn when cookies are unavailable
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-01 02:00 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2012-05-26 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
e-web-app-utils: warn when cookies are unavailable (1.02 KB, patch)
2012-04-01 02:00 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2012-04-01 02:00:38 UTC 
Instead of silently going nuts in the console. Warn that we are unable
to copy the cookies from the session.

Notice that this is a extreme corner case. This would mean that WebKit
has not needed a cookie jar so far, nor that our EphyEmbedPrefs code
was able to attach a cookie jar to the default session.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2012-04-01 02:00:40 UTC 
Created attachment 211052 [details] [review]
e-web-app-utils: warn when cookies are unavailable
Comment 2 Xan Lopez 2012-04-02 09:58:06 UTC 
Review of attachment 211052 [details] [review]:

If there's reasonable cases where we should not have a cookie jar, this should just do silently do nothing. If there aren't, I think it should be an error (g_return_if_fail).
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2012-04-02 10:31:16 UTC 
(In reply to comment #2)
> Review of attachment 211052 [details] [review]:
> 
> If there's reasonable cases where we should not have a cookie jar, this should
> just do silently do nothing. If there aren't, I think it should be an error
> (g_return_if_fail).

The case would be that ephy_embed_prefs_init has not run and hence our cookie jar has not been connected to the WebKit session and WebKit has not yet created one of its own because it has not needed to.
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2012-04-02 10:32:48 UTC 
I would not object to silently do nothing. The web-app can create its own cookie jar later.

The current cookie jar is not that vital. Worst case the user will need to log in again.
Comment 5 Xan Lopez 2012-04-26 19:16:59 UTC 
(In reply to comment #4)
> I would not object to silently do nothing. The web-app can create its own
> cookie jar later.
> 
> The current cookie jar is not that vital. Worst case the user will need to log
> in again.

As I said, it seems more reasonable to me to either accept this can happen (do nothing) or fail. If you think silent fail is better go for it.
Comment 6 Diego Escalante Urrelo (not reading bugmail) 2012-05-26 22:28:16 UTC 
I went for a simple silent return, considering that the situation is not
the end of the world, as we discussed in the comments.

Attachment 211052 [details] pushed as 737dfa9 - e-web-app-utils: warn when cookies are unavailable