After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673269 - Move libsushi into a package private directory
Move libsushi into a package private directory
Status: RESOLVED FIXED
Product: sushi
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Sushi maintainer(s)
Sushi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-04-01 01:52 UTC by Michael Biebl
Modified: 2012-04-11 16:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
PATCH] build: move libsushi out of $libdir (2.19 KB, patch)
2012-04-01 01:55 UTC, Michael Biebl 		none Details | Review
Rebased patch on top of current git master (2.20 KB, patch)
2012-04-01 02:19 UTC, Michael Biebl 		committed Details | Review

Description Michael Biebl 2012-04-01 01:52:45 UTC 
libsushi is not meant to be a public library
The attached patch moves the library (along with the typlib/gir files) into a package private directory.

I've already submitted a similar patch for gnome-documents [1]


[1] http://git.gnome.org/browse/gnome-documents/commit/?id=a04a1eee491d7f0df83abfb00e610340b5fe1f19
Comment 1 Michael Biebl 2012-04-01 01:55:17 UTC 
Created attachment 211051 [details] [review]
PATCH] build: move libsushi out of $libdir
Comment 2 Michael Biebl 2012-04-01 02:19:38 UTC 
Created attachment 211057 [details] [review]
Rebased patch on top of current git master
Comment 3 Cosimo Cecchi 2012-04-01 17:42:29 UTC 
Review of attachment 211057 [details] [review]:

Thanks Michael, looks good!
I'd rather wait after sushi is branched for gnome-3-4 before committing it though.
Comment 4 Michael Biebl 2012-04-02 00:25:50 UTC 
(In reply to comment #3)
> I'd rather wait after sushi is branched for gnome-3-4 before committing it
> though.

No problem, thanks for the review!
FWIW, I ship this patch in the Debian package, so it has at least some wider testing.
Comment 5 Cosimo Cecchi 2012-04-11 16:45:05 UTC 
Pushed to master now.