After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673162 - "Enable" account menu item doesn't connect the account
"Enable" account menu item doesn't connect the account
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.33.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-30 11:59 UTC by Guillaume Desmottes
Modified: 2012-03-30 12:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
accounts_dialog_enable_account_cb: use the usual async cb pattern (1.55 KB, patch)
2012-03-30 12:00 UTC, Guillaume Desmottes 		committed Details | Review
accounts-dialog: no need to connect the account if we are disabling it (1.92 KB, patch)
2012-03-30 12:00 UTC, Guillaume Desmottes 		committed Details | Review
factor out enable_and_connect_account() (1.27 KB, patch)
2012-03-30 12:00 UTC, Guillaume Desmottes 		committed Details | Review
use enable_and_connect_account() when enabling an account from the menu (886 bytes, patch)
2012-03-30 12:00 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-03-30 11:59:07 UTC 
It doesn't set the presence to online as the GtkSwitch does.
Comment 1 Guillaume Desmottes 2012-03-30 12:00:42 UTC 
Created attachment 210944 [details] [review]
accounts_dialog_enable_account_cb: use the usual async cb pattern

No semantic change.
Comment 2 Guillaume Desmottes 2012-03-30 12:00:45 UTC 
Created attachment 210945 [details] [review]
accounts-dialog: no need to connect the account if we are disabling it
Comment 3 Guillaume Desmottes 2012-03-30 12:00:48 UTC 
Created attachment 210946 [details] [review]
factor out enable_and_connect_account()
Comment 4 Guillaume Desmottes 2012-03-30 12:00:51 UTC 
Created attachment 210947 [details] [review]
use enable_and_connect_account() when enabling an account from the menu
Comment 5 Xavier Claessens 2012-03-30 12:03:35 UTC 
+1
Comment 6 Guillaume Desmottes 2012-03-30 12:39:18 UTC 
Attachment 210944 [details] pushed as a787e76 - accounts_dialog_enable_account_cb: use the usual async cb pattern
Attachment 210945 [details] pushed as 02453f3 - accounts-dialog: no need to connect the account if we are disabling it
Attachment 210946 [details] pushed as 073f8a0 - factor out enable_and_connect_account()
Attachment 210947 [details] pushed as aa9ae0f - use enable_and_connect_account() when enabling an account from the menu