After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673010 - Recent try to downgrade soname to 2 again did not work
Recent try to downgrade soname to 2 again did not work
Status: RESOLVED FIXED
Product: gdl
Classification: Other
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: Anjuta maintainers
Anjuta maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-28 16:53 UTC by Gert Kulyk
Modified: 2012-05-18 09:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Gert Kulyk 2012-03-28 16:53:09 UTC
Recent commit 4e97662 on master was to revert the soname bump to 3 back to 2. But because you decremented GDL_CURRENT and incremented GDL_AGE, the resulting soname will be 1 instead of two. If you're incrementing AGE you'll need to increment CURRENT, too.
Comment 1 Johannes Schmid 2012-03-28 17:16:17 UTC
Yep, should have been reading the comment in the configure.ac correctly but it does it harm much, I mean, it's 2:0:1 for the version string now.
Comment 2 Gert Kulyk 2012-03-28 17:52:22 UTC
It does harm in a way that everyone who was building gdl 3.3.9x linked apps against libgdl-3.so.2, now there is a downgrade to libgdl-3.so.1, so you are forced to rebuild everything depending on gdl. Of course the same is true for people who did a rebuild against 3.4.0 (libgdl-3.so.3) and now are installing the new gdl version.
Comment 3 Johannes Schmid 2012-03-29 05:53:42 UTC
Yep I messed that up but that's kind of what .0 releases are for. However, the correct so name is still 2. Can you please check if that would fix it for you than I would make a new release:

http://git.gnome.org/browse/gdl/commit/?h=gnome-3-4
Comment 4 Michael Biebl 2012-03-29 09:48:43 UTC
(In reply to comment #3)
> Yep I messed that up but that's kind of what .0 releases are for. However, the
> correct so name is still 2. Can you please check if that would fix it for you
> than I would make a new release:
> 
> http://git.gnome.org/browse/gdl/commit/?h=gnome-3-4

The soversion is still 1 in current git head.
Let's assume 2 was correct in 3.3.9:
There has been a API addition between 3.3.90, so bumping CURRENT to 3 is correct.
As the API change was backwards compatible, you also need to bump AGE to 1.

The soversion is computed by CURRENT-AGE = 3-1 = 2
In current git head it is 1-0 = 1

libtool library versioning takes a bit time to get used to
The full details are at
http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
Comment 5 Michael Biebl 2012-03-29 10:06:34 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > 
> > http://git.gnome.org/browse/gdl/commit/?h=gnome-3-4
> In current git head it is 1-0 = 1
> 

Apologies. Apparently I can't read. in the gnome-3-4 branch it is 2-0=2 now, so the soname is fine now.

Strictly speaking, as you had a backwardcompatible API change between 3.3.90 and 3.4.0, CURRENT:REVISION:AGE 3:0:1 would have been slightly more correct, but the resulting soname is the same (3-1=2), so it doesn't matter that much.
Comment 6 Gert Kulyk 2012-03-29 18:39:30 UTC
Yep, if 2 is the targetted soname, the commited change in gnome-3-4 branch should fix it, as Michael stated above.
Comment 7 Johannes Schmid 2012-04-22 19:34:44 UTC
Sorry for the late reply.

Should I change this to 3:0:1 for the 3.4.1 release or would that just cause more trouble for you?
Comment 8 Michael Biebl 2012-04-22 19:37:00 UTC
I'd appreciate a package with a fixed soname for GNOME 3.4.1