GNOME Bugzilla – Bug 672853
Assistant layout is broken
Last modified: 2016-03-31 14:01:34 UTC
See attached screenshot; gnome-boxes 3.3.92 on Fedora 17.
Created attachment 210622 [details] screenshot
Ah interesting, I saw something similar when running with the French translation, but not with LC_ALL=C. No other clue though.
Getting this with LC_ALL=C now and 3.4.0 from jhbuild
it probably has something to do with bug 672557: the code in TableLayout has been resynchronised with MxTable (from which it came originally) to incorporate fixes that happened during the last year or so - and it may have broken something. I'll look at it ASAP. in the meantime, reassigning the bug to Clutter.
Created attachment 210759 [details] [review] table-layout: Fix [xy]_expand trivial fix. testing appreciated.
Unfortunately this doesn't seem to help. I applied the patch, rebuilt/reinstalled clutter, checked that the libclutter.so gnome-boxes is using changed on disk, but I still get a broken layout in the assistant
I went back to 229241b87 actor: Remove the implicit easing state save (randomly chosen rev from some time ago) and I'm still getting this issue, so I'm not sure clutter is to blame there.
Review of attachment 210759 [details] [review]: Whoops, yeah.
Comment on attachment 210759 [details] [review] table-layout: Fix [xy]_expand Attachment 210759 [details] pushed as 3c1358d - table-layout: Fix [xy]_expand
it would be fantastic if you could bisect Clutter to find the commit that broke - though I'm pretty sure that TableLayout hasn't been touched in a while, except the latest few commits. the latest changes were in January, and they were compiler warning fixes.
re-assigning to Boxes, as per comment 7 and discussion on IRC.
We really need to fix this ASAP. While this issue is not 'blocker' in the wizard, properties view is totally unusable because of this.
Created attachment 210836 [details] [review] layout: fix broken Wizard and Properties layout A recent change in clutter has introduced a regression in Boxes: 8c0be4181bc48917535177b3ce61f87d78f0c27d It seems to use the first column/row expand value for the rest of the table cells. Further investigation needed with Clutter gang. For now, let's just remove expand from the topbar, which spans over 2 cells.
the rationale for the change in Clutter would be that if a widget is set to expand and is spanning more than one column, then all the columns covered should be expanding, to match the request of the actor. we can probably figure out a way to amend the policy, though that may require doing multiple passes on the list of actors.
Comment on attachment 210836 [details] [review] layout: fix broken Wizard and Properties layout Works here and from what I understood from last comment, this is the right thing to do any ways?
Attachment 210836 [details] pushed as 0f09465 - layout: fix broken Wizard and Properties layout
While I made sure that the fix gets into F17, I now found out that this issue is still reproducible *somehow* on F17 against Boxes 3.4.0.1 (which contains these fixes). :(
Turns out that the attachment#210759 [details] got forgotten and didn't make it to fedora 17.
To be honest, I only realized yesterday that this patch was also needed to fix the breakage, and I probably was not the only one. Since this patch hasn't been part of a clutter release yet, it's no surprise it's not there yet. Have you filed a bug against the fedora package already?
(In reply to comment #19) > Since this patch hasn't been > part of a clutter release yet, it's no surprise it's not there yet. Have you > filed a bug against the fedora package already? No, I did something better. I sent a patch against clutter fedora package to Matthias Clasen and he promised to push it ASAP.