After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672801 - [gdm] always starts gnome-session with debugging enabled
[gdm] always starts gnome-session with debugging enabled
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
3.2.x
Other Linux
: High critical
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-25 13:09 UTC by xtragb
Modified: 2012-10-27 17:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
slave: only start gnome-session with --debug if debug enabled (1.91 KB, patch)
2012-06-08 15:06 UTC, Ray Strode [halfline]
committed Details | Review

Description xtragb 2012-03-25 13:09:45 UTC
/gdm/src/gdm-greeter-session.c is hardcoded to start gnome-session in debug mode

Offending code block:

object = g_object_new (GDM_TYPE_GREETER_SESSION,
"command", BINDIR "/gnome-session -f --debug",
"server-dbus-path", GDM_GREETER_SERVER_DBUS_PATH,
"server-dbus-interface", GDM_GREETER_SERVER_DBUS_INTERFACE,
"server-env-var-name", "GDM_GREETER_DBUS_ADDRESS",
"register-ck-session", TRUE,
"x11-display-name", display_name,
"x11-display-seat-id", seat_id,
"x11-display-device", display_device,
"x11-display-hostname", display_hostname,
"x11-display-is-local", display_is_local,
"runtime-dir", GDM_SCREENSHOT_DIR,
NULL);

Some users may not want or need gnome-session debug info in their logs; with the gnome-session --debug option hardcoded, a user cannot disable debugging if gnome-session is started by gdm.
Comment 1 Ray Strode [halfline] 2012-03-26 14:58:04 UTC
we really want debugging in the logs so that when users file bug reports, the logs are there. It's helped us numerous times in the past since we made the change.

The greeter session output goes to its own file (/var/log/gdm/\:0-greeter.log) so it's not like we're polluting syslog or anything the user routinely looks through.
Comment 2 xtragb 2012-03-26 20:40:31 UTC
Ray,

I see where you are coming from and completely understand if you don't want to change this. I guess it wouldn't have bothered me in the past but for the last two months I've been using systemd with systemd-journalctl as my syslog, which seems to lump everything together in its output - including about 6 pages of greeter session output :(

Jonathan
Comment 3 Ray Strode [halfline] 2012-03-26 20:51:40 UTC
that's odd, we don't put greeter messages in syslog. what distro?
Comment 4 xtragb 2012-03-26 21:22:38 UTC
I'm running Arch Linux.
Comment 5 xtragb 2012-03-27 01:08:28 UTC
But according to the systemd-journalctl man page:

"Output is interleaved from all accessible journal files, whether they are rotated or currently being written, and regardless whether they belong to the system itself or are accessible user journals."  

Apparently that includes /var/log/gdm/\:0-greeter.log
Comment 6 Ray Strode [halfline] 2012-04-09 22:00:18 UTC
so it turns out gnome-session automatically goes to syslog when started with --debug....reopening.
Comment 7 David Dreggors 2012-06-08 00:49:49 UTC
I am running Fedora 17 and see tons of these DEBUG messages from gnome-session in my /var/log/messages file.

This has been happening since Fedora 16 actually, in fact there are sever Fedora bugs opened for this that were opened for Fedora 16 and are still open with no resolution.

The entries start with "gnome-session[2179]: DEBUG(+): ".

Here are 2 of the bug reports at Fedora, there are more but a quick search at fedora's bugzilla should show you that...

https://bugzilla.redhat.com/show_bug.cgi?id=755135

https://bugzilla.redhat.com/show_bug.cgi?id=759737
Comment 8 Ray Strode [halfline] 2012-06-08 15:05:27 UTC
Okay, should be set now.
Comment 9 Ray Strode [halfline] 2012-06-08 15:06:24 UTC
Created attachment 215969 [details] [review]
slave: only start gnome-session with --debug if debug enabled

gnome-session puts all its message in syslog when --debug is
enabled.  This floods the log and makes it hard to see other
messages.

This commit only calls gnome-session with --debug when gdm
debugging is on.
Comment 10 Ray Strode [halfline] 2012-06-08 15:06:39 UTC
Attachment 215969 [details] pushed as 74fc442 - slave: only start gnome-session with --debug if debug enabled
Comment 11 David Dreggors 2012-06-08 21:16:15 UTC
When do you think we can expect to see this in Fedora (16/17) Ray?

Since you are assigned to the Fedora bug reports for this issues, I figured I would ask you here at the source.
Comment 12 Ray Strode [halfline] 2012-06-08 22:52:56 UTC
Not sure, not likely to push gdm 3.5 to f17, but could backport the patch.
Comment 13 Ray Strode [halfline] 2012-06-08 23:03:11 UTC
pushing builds for f16/f17 now