GNOME Bugzilla – Bug 672786
goa-daemon: action in notification doesn't work
Last modified: 2012-04-26 21:16:39 UTC
The action to launch the online accounts panel from the 'account needs attention' notification doesn't work, because the DISPLAY is not set in the app launch context. We need to either use a GdkAppLaunchContext (but then the daemon probably needs to initialize gtk), or explicitly pass DISPLAY on (which may not be trivial with GAppLaunchContext, unfortunately)
This is because of a bug in glib2 introduced by: commit de834bed306565c0652050665eafff4dfcdf0d8b Author: Dan Winship <danw@gnome.org> Date: Sat Oct 15 16:59:59 2011 -0400 GAppLaunchContext: add environment-manipulating functions Add functions for manipulating the environment under which a GAppLaunchContext will launch its children, to avoid thread-related bugs with using setenv() directly. FIXME: win32 side isn't implemented yet https://bugzilla.gnome.org/show_bug.cgi?id=659326
Created attachment 212169 [details] [review] GAppInfo: overwrite the DISPLAY only if it is set in the launch context
Pushed to master and glib-2-32. From #gtk+: 21:04 <rishi> mclasen: Hey! Did you notice that glib bug that moved from GOA? 21:05 <mclasen> no, I didn't 21:05 <rishi> mclasen: I think it might be useful to have that fix in F17. 21:05 <mclasen> or wait, is that the one about DISPLAY ? 21:05 <rishi> mclasen: Yes. That one. 21:05 <mclasen> ok 21:05 <mclasen> we should commit the fix upstream first, I guess 21:05 <mclasen> and put it on the stable branch as well 21:05 <rishi> mclasen: Yes. Exactly.