After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672718 - [PATCH] Crash in user accounts when autologin changes
[PATCH] Crash in user accounts when autologin changes
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: User Accounts
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-23 20:09 UTC by Michael Terry
Modified: 2012-07-16 11:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.55 KB, patch)
2012-03-23 20:09 UTC, Michael Terry 		reviewed Details | Review

Description Michael Terry 2012-03-23 20:09:24 UTC 
Created attachment 210482 [details] [review]
Proposed patch

In Ubuntu, we had a reported crash (https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/873679) with a stack trace like:

 um_user_set_automatic_login (user=0x0, enabled=1) at um-user.c:1075
 autologin_changed (object=<optimized out>, pspec=<optimized out>, d=0x7fb07d40d280) at um-user-panel.c:532

Which would happen if the autologin switch changed but there is no selected user...?  I couldn't reproduce myself.  But it seems to happen for some users.

I have a patch here that fixes this problem two different ways, either one of which would be sufficient for this specific path, but both seem sensible changes anyway.
Comment 1 Bastien Nocera 2012-03-26 09:23:58 UTC 
Review of attachment 210482 [details] [review]:

Seems to be papering over the cracks. I'd really prefer a way to reproduce the problem.
Comment 2 Matthias Clasen 2012-03-27 05:27:16 UTC 
I guess this could be another instance of uid < UID_MIN causing trouble ?
We're getting that fixed in the next accountsservice release (today).
Comment 3 Matthias Clasen 2012-03-28 23:43:43 UTC 
The UID_MIN check has been removed in accountsservice 0.6.17
Comment 4 Bastien Nocera 2012-03-28 23:52:21 UTC 
Please check with accountsservice 0.6.17.
Comment 5 Tobias Mueller 2012-07-16 11:32:42 UTC 
k. we believe this to be OBSOLETE. Please reopen if this is still an issue.