GNOME Bugzilla – Bug 672591
wireless strength indicator is hidden when on VPN
Last modified: 2012-06-20 21:24:48 UTC
The wireless strength indicator is hidden when on VPN. This doesn't seem like a good thing to me.
It used to be like that, and was changed in bug 665115, with the argument that knowing if VPN is available or not (for example to access internal resources) is more important than knowing the underlying connection. (Anyway, I'm not sure it can be considered 3.4 material, at this point)
(In reply to comment #1) > It used to be like that, and was changed in bug 665115, with the argument that > knowing if VPN is available or not (for example to access internal resources) > is more important than knowing the underlying connection. It never was like that...note that the proposal of this bug is to use *two* icons for the network indicator in the panel when on wireless and VPN.
Hiding variable signal indicators makes absolutely no sense to me. Hiding wired seems fine however.
Created attachment 210366 [details] [review] NetworkMenu: prefer wifi/3g over vpn in the panel Wifi and mobile broadband have signal indicators, and therefore are more useful than vpn icons in the panel. We still special case vpn over wired and, when supported in the future, other kind of connections. Ok, here you have the fix. IMHO, this breaks UI freeze in the specific case, and I'm not sure it's worth an exception. Anyway, it surely breaks hard code freeze, so it's 3.4.1 at least.
Review of attachment 210366 [details] [review]: It is not about preferring one icon over the other, but to show both under some circumstances.
(In reply to comment #4) > Ok, here you have the fix. I tested the patch, but it doesn't seem to do what this bug report asks for. To be clear, I think the desired layout of indicator icons requested by this bug would be (excuse the poor ASCII art): - Wired with no VPN [ A11Y | SOUND | BT | WIRED | POWER | CHAT-STATUS + NAME ] (same as now) - Wired + VPN [ A11Y | SOUND | BT | VPN-LOCK | POWER | CHAT-STATUS + NAME ] (same as now) - Wireless/3G with no VPN [ A11Y | SOUND | BT | SIGNAL-STRENGTH | POWER | CHAT-STATUS + NAME ] (same as now) - Wireless/3G + VPN [ A11Y | SOUND | BT | SIGNAL-STRENGTH + VPN-LOCK | POWER | CHAT-STATUS + NAME ]
Created attachment 210372 [details] [review] NetworkMenu: prefer wifi/3g over vpn in the panel Wifi and mobile broadband have signal indicators and are thus more useful than vpn icons in the panel. Therefore, in the case we have both wifi/3g and VPN we prefer the former as the "primary icon" and add a lock next to it. Behavior when VPN is added to wired or other connections is still preserved: the wired icon is replaced by vpn. ----- I understand my previous comment (and patch) could have sounded rude, and I'm sorry. Anyway, I hope this patch improves things on VPN+wifi interaction.
Created attachment 210709 [details] [review] NetworkMenu: prefer wifi/3g over vpn in the panel Another iteration of the patch, based on Giovanni's version.
(In reply to comment #7) > I understand my previous comment (and patch) could have sounded rude, > and I'm sorry. Anyway, I hope this patch improves things on VPN+wifi > interaction. Hey Giovanni; I found some time to test your patch today, but it still wasn't working as expected. The problem here is that NMApplet is initially a PanelMenu.ButtonBox, which despite the name, is a single-child container. So you can't just add another icon to it, but you have to pack both icons into a box before. I tested this version of patch now and it works fine. I am only a bit unsure about the spacing when both the icons are showing; attaching a screenshot to get designer's feedback.
Created attachment 210711 [details] screenshot
*** Bug 677182 has been marked as a duplicate of this bug. ***
(In reply to comment #9) > Hey Giovanni; I found some time to test your patch today, but it still wasn't > working as expected. The problem here is that NMApplet is initially a > PanelMenu.ButtonBox, which despite the name, is a single-child container. So > you can't just add another icon to it, but you have to pack both icons into a > box before. I think that was just a quick hack when it landed. You can probably add support to allocate all children with spacing / 2 or something.
Spacing looks decent to me.
Created attachment 216841 [details] [review] NetworkMenu: prefer wifi/3g over vpn in the panel New version of the patch; I tried to make the separation between VPN and other connections a bit clearer in the code; this also fixes some problems in the previous patch where we were not displaying the "activating" state of the VPN connection as a separate icon with wireless connections.
Review of attachment 216841 [details] [review]: Ok, let's get this going.
Attachment 216841 [details] pushed as 61de3de - NetworkMenu: prefer wifi/3g over vpn in the panel Thanks Giovanni, pushed to master.