After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672557 - Fix ClutterTableLayout
Fix ClutterTableLayout
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-21 14:38 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-03-21 15:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
table-layout: Remove unused 'shrink' field. (852 bytes, patch)
2012-03-21 14:38 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
table-layout: Fix column visibility for spanning actors (1.55 KB, patch)
2012-03-21 14:38 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
table-layout: Fix x/y-expand for spanning actors (1.37 KB, patch)
2012-03-21 14:38 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
table-layout: Fix column visibility for spanning actors (1.55 KB, patch)
2012-03-21 14:43 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
table-layout: Remove dead code (2.07 KB, patch)
2012-03-21 14:43 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-03-21 14:38:35 UTC 
MxTable had a number of issues related to spanning actors, that have
since been fixed. Port those issues forward into ClutterTableLayout.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-03-21 14:38:37 UTC 
Created attachment 210241 [details] [review]
table-layout: Remove unused 'shrink' field.

Ported to ClutterTableLayout from MxTable:

https://github.com/clutter-project/mx/commit/053a1b04290e6ac307f90033babf761179d1db89
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-03-21 14:38:39 UTC 
Created attachment 210242 [details] [review]
table-layout: Fix column visibility for spanning actors

Ported to ClutterTableLayout from MxTable:

https://github.com/clutter-project/mx/commit/6633f185fcfb7ce8a6ef85276d09e4ee92f584b8
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-03-21 14:38:41 UTC 
Created attachment 210243 [details] [review]
table-layout: Fix x/y-expand for spanning actors

Ported to ClutterTableLayout from MxTable:

https://github.com/clutter-project/mx/commit/239e53146a678ae753b1fb9a862f4030c66a1d9b
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-03-21 14:43:27 UTC 
Created attachment 210244 [details] [review]
table-layout: Fix column visibility for spanning actors

Ported to ClutterTableLayout from MxTable:

https://github.com/clutter-project/mx/commit/6633f185fcfb7ce8a6ef85276d09e4ee92f584b8



It helps to make sure your changes compile before attaching them, of course.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-03-21 14:43:48 UTC 
Created attachment 210245 [details] [review]
table-layout: Remove dead code

If a column/row is expanding, n_expand has to be greater than 1.
Comment 6 Emmanuele Bassi (:ebassi) 2012-03-21 15:04:27 UTC 
Review of attachment 210241 [details] [review]:

okay
Comment 7 Emmanuele Bassi (:ebassi) 2012-03-21 15:04:53 UTC 
Review of attachment 210243 [details] [review]:

okay
Comment 8 Emmanuele Bassi (:ebassi) 2012-03-21 15:05:26 UTC 
Review of attachment 210244 [details] [review]:

okay
Comment 9 Emmanuele Bassi (:ebassi) 2012-03-21 15:06:03 UTC 
Review of attachment 210245 [details] [review]:

the coding style is a bit off, but I'll allow it
Comment 10 Jasper St. Pierre (not reading bugmail) 2012-03-21 15:41:41 UTC 
Attachment 210241 [details] pushed as 67ddf87 - table-layout: Remove unused 'shrink' field.
Attachment 210243 [details] pushed as 8c0be41 - table-layout: Fix x/y-expand for spanning actors
Attachment 210244 [details] pushed as 16d2885 - table-layout: Fix column visibility for spanning actors
Attachment 210245 [details] pushed as 40c345a - table-layout: Remove dead code