Created attachment 210158 [details] [review]
Reset EPGScanner on error instead of stopping it

Comment on attachment 210158 [details] [review]
Reset EPGScanner on error instead of stopping it

Calling reset will clear the channels queue and stop monitoring the bus, that's not want you want. You want to resume scanning with the next channel. I believe calling neither stop nor reset should do it, because scanning of the next channel is still in queue. Try with removing the call to reset.

Sure, that could work even better, I think the pipeline needs resetting, though, when an error caused it to stop (dvb-read-failure not so).

My thinking was that resetting would be ok so as to cater that there was, indeed, a failure (a pipeline failure, that is - dvb-read-failure can probably be simply ignored), and trying over and over again might not help, but resetting might.

I'll go with what you think is best, though.

Good point, with an error we are not able to recover and can re-use the current pipeline. This means we have to create a new pipeline in this case. That's basically the pipeline part in reset plus the one in the start method.

Created attachment 210205 [details] [review]
Make the epg scanner more robust

Review of attachment 210205 [details] [review]:

Thanks a lot, committed to master.