GNOME Bugzilla – Bug 672309
LLVM Syntax Highlighting
Last modified: 2014-02-06 14:52:31 UTC
Hello. I have created a syntax highlighting file for LLVM (llvm.org). I went through the language specification and I think I added everything. I hope you will add it to the trunk. Otherwise I hope people finding this bug will be helped. Installation instructions are in the file. Regards, Stefan Sundin
Created attachment 210014 [details] LLVM Syntax Highlighting
Forgive my ignorance, but which part of llvm is the lang file highlighting? As far as I know llvm is a compiler... which files would this work with? From a formal point of view the lang file looks mostly good, some minor nitpicks: - use two-spaced indent instead of tabs - we include mimetype only if they are part of shared-mime-info, otherwise we omit them (that metadata is not mandatory)
LLVM is a collection of many tools related to compilers. Perhaps the main point of LLVM is an intermediate representation the rest of the tools are centered around. It's like assembler, but not machine specific. You can then run optimizations on the intermediate representation before compiling it into assembler or a final executable. You can compile ordinary C programs to LLVM IR by using clang: clang -cc1 -emit-llvm foo.c Then you can further compile foo.ll into an executable with this: llc foo.ll Feel free to fix the minor issues that you listed, or if you want I will do it. And I don't think that mimetype is in shared-mime-info.
Ah ok, so this is for LLVM intermediate representation. If you could update the file as suggested it would be great. Even better if also add it to Makefile.am, po/POTFILES.in, include a small test snippet in tests/testfiles.sh and provide the whole thing in as in the "git format-patch" format so that it can be included preserving your name etc. No hurry though we are frozen for 3.4 so this will have to wait a bit
Ah, also to be included the file must be licensed as LGPL v2 as the other lang files.
Created attachment 210279 [details] [review] git format-patch All issues should be fixed in this one.
The commit is pushed, thanks for your patch. https://git.gnome.org/browse/gtksourceview/commit/?id=b10d067620880e010d7111f35c6568422642c2ad