Created attachment 209965 [details] [review]
userMenu: Consider account-validity for sensitivity

We currently only update the status chooser's sensitivity if accounts
are added, removed or enabled; unfortunately during account creation,
the account may become enabled before it is actually valid, so the
status chooser remains insensitive. Fix by listening to validity changes
as well.

Review of attachment 209965 [details] [review]:

::: js/ui/userMenu.js
@@ +288,3 @@
     _IMAccountsChanged: function(mgr) {
         let accounts = mgr.get_valid_accounts().filter(function(account) {
+            return account.valid && account.enabled;

Isn't the account manager returning only valid accounts already? i.e. wasn't the condition OK as it was?

Created attachment 209971 [details] [review]
userMenu: Consider account-validity for sensitivity

(In reply to comment #2)
> Isn't the account manager returning only valid accounts already? i.e. wasn't
> the condition OK as it was?

Yeah, you're right - fixed.

Review of attachment 209971 [details] [review]:

Looks fine. I'm not able to test this today, so if it fixes the problem for you, go ahead and push.

Attachment 209971 [details] pushed as cf0b6dd - userMenu: Consider account-validity for sensitivity