After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672109 - Untranslated strings in gnomine
Untranslated strings in gnomine
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: gnomine
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-14 23:56 UTC by Gabor Kelemen
Modified: 2012-03-15 12:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Mark strings for translation, correct the looked up string (2.31 KB, patch)
2012-03-15 00:01 UTC, Gabor Kelemen
committed Details | Review

Description Gabor Kelemen 2012-03-14 23:56:15 UTC
I have found a few strings which are not marked for translation, and a dpgettext call that tries to localize the "_Custom" string, but there is only "Custom" marked for translation with the given context.
Comment 1 Gabor Kelemen 2012-03-15 00:01:17 UTC
Created attachment 209792 [details] [review]
Mark strings for translation, correct the looked up string
Comment 2 Robert Ancell 2012-03-15 00:04:01 UTC
Review of attachment 209792 [details] [review]:

Looks good.  You probably don't need to mark the warning as translatable though - it's only shown if the help fails to open and it's shown to stderr so normal users wont see it.
Comment 3 Gabor Kelemen 2012-03-15 12:21:55 UTC
Review of attachment 209792 [details] [review]:

Okay, removed the marking of the warning and pushed, thanks!