After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672047 - Orca just present "Panel" with contacts on the overview
Orca just present "Panel" with contacts on the overview
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-14 12:48 UTC by Alejandro Piñeiro Iglesias (IRC: infapi00)
Modified: 2012-03-15 19:39 UTC
See Also:
GNOME target: 3.4
GNOME version: 3.3/3.4


Attachments
Setting label actor and role for Contacts on the overview (1.70 KB, patch)
2012-03-14 12:57 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00)
committed Details | Review

Description Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-03-14 12:48:29 UTC
STEPS TO REPRODUCE

1. Launch Orca
2. Go to the overview (Alt+F1) and search for a contact (probably you would need evolution, empathy or something like that configured).
3. Select that contact

EXPECTED OUTCOME

Orca exposes "alias push button"

ACTUAL OUTCOME

Orca exposes "Panel"
Comment 1 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-03-14 12:57:56 UTC
Created attachment 209709 [details] [review]
Setting label actor and role for Contacts on the overview

Easy patch.

I'm also wondering if it is worth to expose the status.

Anyway right now it is easily implementable. label_actor property is a one-to-one relation. We could think on improve this, in order to have several labels labeling and actor, ala gtk_widget_add_mnemonic_label (as label_actor is somehow a simplification of that method). FWIW, on ATK you can set the LABEL_FOR relationships several times.

Anyway, taking into account how near is hard code freeze, this is something to talk about in the future, and right now name and label should be perfectly enough.
Comment 2 Dan Winship 2012-03-15 17:47:35 UTC
Comment on attachment 209709 [details] [review]
Setting label actor and role for Contacts on the overview

i haven't seen the new contacts thing, but I assume these changes are right...
Comment 3 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-03-15 19:39:42 UTC
(In reply to comment #2)
> (From update of attachment 209709 [details] [review])
> i haven't seen the new contacts thing, but I assume these changes are right...

<API> danw, one question about this review:
<API> https://bugzilla.gnome.org/show_bug.cgi?id=672047#c2
<API> it is not clear to me if I can commit that patch
<drago01> API: it is more of "if it works commit it"

Well, it works for me and Joanmarie tested it, and also works for her. As I said on comment 1, the only missing stuff is exposing the contact status, but this is something that would need to wait for 3.6.

So, committing and closing the bug