After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671857 - Add deprecation attributes to deprecated functions
Add deprecation attributes to deprecated functions
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-03-11 23:39 UTC by Javier Jardón (IRC: jjardon)
Modified: 2012-03-16 17:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add deprecation attributes to deprecated functions (1.80 KB, patch)
2012-03-11 23:41 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2012-03-11 23:39:24 UTC 
This is using the newly introduce G_DEPRECATED macros
from GLib. Traditional deprecation guards are still in
place.
Comment 1 Javier Jardón (IRC: jjardon) 2012-03-11 23:41:10 UTC 
Created attachment 209457 [details] [review]
Add deprecation attributes to deprecated functions
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-03-12 12:15:40 UTC 
Review of attachment 209457 [details] [review]:

Looks good
Comment 3 Javier Jardón (IRC: jjardon) 2012-03-12 12:57:12 UTC 
Comment on attachment 209457 [details] [review]
Add deprecation attributes to deprecated functions

commit d21780818439f690014ca3ce752310ac618b2f86
Comment 4 Javier Jardón (IRC: jjardon) 2012-03-12 12:57:31 UTC 
Thanks for the fast review!
Comment 5 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-03-16 17:00:53 UTC 
Urgh it seems that we forget to update GLIB_REQUIRED_VERSION:

https://mail.gnome.org/archives/orca-list/2012-March/msg00147.html