After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671849 - "Game over" text is not scaled to the window size
"Game over" text is not scaled to the window size
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: swell-foop
trunk
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-11 21:28 UTC by Thomas Andersen
Modified: 2012-03-17 09:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Scale the text actor to the scene size (2.35 KB, patch)
2012-03-11 21:28 UTC, Thomas Andersen 		committed Details | Review
Before (20.13 KB, image/png)
2012-03-14 23:41 UTC, Thomas Andersen 		  Details
After (26.03 KB, image/png)
2012-03-14 23:41 UTC, Thomas Andersen 		  Details

Description Thomas Andersen 2012-03-11 21:28:42 UTC 
Created attachment 209449 [details] [review]
Scale the text actor to the scene size

When playing the small board the text is way too big to fit the screen. The problem is that the size of the actor for the text is calculated from the given text and font size. The current setting fits the large board but does not fit the small.

The attached patch fixes the problem by adjusting the scale when the actor animates.
Comment 1 Thomas Andersen 2012-03-14 23:41:02 UTC 
Created attachment 209790 [details]
Before
Comment 2 Thomas Andersen 2012-03-14 23:41:29 UTC 
Created attachment 209791 [details]
After
Comment 3 Robert Ancell 2012-03-14 23:47:14 UTC 
If you're looking for a review, then I confirm the bug and agree with the solution.
Comment 4 Thomas Andersen 2012-03-14 23:52:56 UTC 
Thanks. I guess this needs a UI freeze approval from the release team.
Comment 5 Robert Ancell 2012-03-15 00:01:01 UTC 
I'd say this is just a standard bug - the current scaling is just wrong and you're not changing any other aspect of it.
Comment 6 Thomas Andersen 2012-03-15 00:03:21 UTC 
I already filed the request so I'll just wait for them to ok it :)
Comment 7 Thomas Andersen 2012-03-17 09:05:11 UTC 
Comment on attachment 209449 [details] [review]
Scale the text actor to the scene size

Got the UI freeze approval. Committed to master:
http://git.gnome.org/browse/gnome-games/commit/?id=6e0cf036f48732541cf58cd10aed96cf905fd0be