After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671737 - [PATCH] configure --disable-gui still build gui code
[PATCH] configure --disable-gui still build gui code
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Build system
2.4.x
Other All
: Normal normal
: ---
Assigned To: Derek Atkins
Christian Stimming
Depends on:
Blocks:
 
 
Reported: 2012-03-09 17:59 UTC by Kuang-che Wu
Modified: 2018-06-29 23:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix (1020 bytes, patch)
2012-03-09 18:00 UTC, Kuang-che Wu 		committed Details | Review
patch 2 (648 bytes, patch)
2012-03-20 17:39 UTC, Kuang-che Wu 		committed Details | Review

Description Kuang-che Wu 2012-03-09 17:59:42 UTC 
How to reproduce
$ ./configure --enable-python --enable-dbi --disable-gui
$ make
It still build GUI related code.

Patch is attached.
Comment 1 Kuang-che Wu 2012-03-09 18:00:52 UTC 
Created attachment 209333 [details] [review]
Fix
Comment 2 Christian Stimming 2012-03-19 20:50:51 UTC 
Comment on attachment 209333 [details] [review]
Fix

r22099, thanks!
Comment 3 Christian Stimming 2012-03-19 20:52:47 UTC 
I didn't include the directory change with src/python, though, because that didn't make too much sense for me.
Comment 4 Kuang-che Wu 2012-03-20 17:39:30 UTC 
Created attachment 210192 [details] [review]
patch 2

You are right. The python part of my previous patch is incorrect.

This is my second patch.

1. "optional" should not be in GUI_SUBDIRS, otherwise python-bindings will not build.
2. lib/stf depends on goffice which depends on gtk. And stf is only used in gnucash impoter, I remove it if GUI is disabled.
Comment 5 Derek Atkins 2012-03-20 17:52:45 UTC 
... Except "optional/gtkmm" *should* only be built when you build the GUI.  So perhaps "optional" needs to be split into GUI and non-GUI portions?
Comment 6 Christian Stimming 2012-03-20 19:45:44 UTC 
Yes. The optional/Makefile.am also needs a "if ENABLE_GUI"... conditional.
Comment 7 Kuang-che Wu 2012-03-21 04:18:08 UTC 
"optional/gtkmm" already guarded by WITH_GTKMM, maybe it is ok.
Unless users specify --disable-gui and --enable-gtkmme at the same time.
Comment 8 Christian Stimming 2012-03-21 20:15:27 UTC 
Comment on attachment 210192 [details] [review]
patch 2

ok. r22105, thanks!
Comment 9 John Ralls 2017-09-24 22:44:09 UTC 
Reassign version to 2.4.x so that individual 2.4 versions can be retired.
Comment 10 John Ralls 2018-06-29 23:07:14 UTC 
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=671737. Please update any external references or bookmarks.