After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671644 - Border overflows not taken in account when drawing Clutter actors in empathy-call
Border overflows not taken in account when drawing Clutter actors in empathy-...
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: VoIP
unspecified
Other Linux
: Normal minor
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-08 13:40 UTC by Emanuele Aina
Modified: 2012-03-09 08:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't clip overflowing border when drawing rounded rectangles (3.56 KB, patch)
2012-03-08 13:43 UTC, Emanuele Aina 		committed Details | Review

Description Emanuele Aina 2012-03-08 13:40:19 UTC 
Cairo draws borders along paths half on the inside and half on the outside, so if you have a box of 100x100px with a border of 5px the resulting object will occupy 105x105px, so special attention is needed to avoid clipping the 2.5px of border on each side.

This happens in nearly all Clutter actors in the empathy call window: video preview highlight box, video preview placeholders, floating bar buttons and the "i" button.
Comment 1 Emanuele Aina 2012-03-08 13:43:38 UTC 
Created attachment 209249 [details] [review]
Don't clip overflowing border when drawing rounded rectangles
Comment 2 Guillaume Desmottes 2012-03-08 15:24:16 UTC 
Review of attachment 209249 [details] [review]:

::: src/empathy-rounded-rectangle.c
@@ +121,1 @@
+  self = EMPATHY_ROUNDED_RECTANGLE (g_object_new (EMPATHY_TYPE_ROUNDED_RECTANGLE, NULL));

Can't we use the surface-width and surface-height properties? See http://cgit.collabora.com/git/user/cassidy/empathy/log/?h=trivia (I wrote it before reviewing your patch :)
Comment 3 Guillaume Desmottes 2012-03-09 08:14:39 UTC 
Attachment 209249 [details] pushed as 2ca7e0f - Don't clip overflowing border when drawing rounded rectangles