After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671534 - [0.11] qtmux: cover art tag is GstSample now
[0.11] qtmux: cover art tag is GstSample now
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.11.x
Other All
: Normal normal
: 0.11.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-07 09:23 UTC by Matej Knopp
Modified: 2012-03-08 11:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (1.31 KB, patch)
2012-03-07 09:23 UTC, Matej Knopp 		committed Details | Review
Do not unref sample caps (742 bytes, patch)
2012-03-08 06:57 UTC, Matej Knopp 		committed Details | Review

Description Matej Knopp 2012-03-07 09:23:02 UTC 
Created attachment 209138 [details] [review]
fix

The code expects gstbuffer (which is wrong)
Comment 1 Tim-Philipp Müller 2012-03-07 10:47:05 UTC 
Thanks!

 commit 688e820573354aa897fde8e6da5438704281e883
 Author: Matej Knopp <matej.knopp@gmail.com>
 Date:   Wed Mar 7 04:20:00 2012 -0500

    qtdemux: covert art tag type is GstSample not GstBuffer now
    
    https://bugzilla.gnome.org/show_bug.cgi?id=671534

(PS: darn, I messed up the commit message, sorry about that. Should have been "qtmux:" of course. I'm sure no one will notice)
Comment 2 Matej Knopp 2012-03-08 06:57:43 UTC 
Created attachment 209232 [details] [review]
Do not unref sample caps

Sorry, I must have missed this in previous mail, the sample caps were unreffed which is not right.
Comment 3 Tim-Philipp Müller 2012-03-08 11:03:54 UTC 
commit 0ee34c293f38ef9656d174382b3a249fdead1638
Author: Matej Knopp <matej.knopp@gmail.com>
Date:   Thu Mar 8 01:53:50 2012 -0500

    qtmux: do not unref sample caps
    
    https://bugzilla.gnome.org/show_bug.cgi?id=671534