After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671465 - Resolution listing order
Resolution listing order
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Display
3.2.x
Other Linux
: Normal enhancement
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-06 13:09 UTC by Olaf van der Spek
Modified: 2012-03-08 09:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
display: Sort resolutions by width first (1.16 KB, patch)
2012-03-07 16:15 UTC, Bastien Nocera
committed Details | Review

Description Olaf van der Spek 2012-03-06 13:09:27 UTC
The resolution listing order looks weird. I guess it's currently sorted by (mega)pixels. Could it be sorted by horizontal and than by vertical pixels instead?
Comment 1 Bastien Nocera 2012-03-06 13:16:37 UTC
Why is that better? What transition between two resolutions are causing problems?
Comment 2 Olaf van der Spek 2012-03-06 13:19:54 UTC
I'm just talking about order in the dropdown in the Display settings. Not about any transition.

The current order looks semi-random to me. The horizontal res is the first value, so ordering by it would look far more natural.
Comment 3 Bastien Nocera 2012-03-06 13:37:52 UTC
(In reply to comment #2)
> I'm just talking about order in the dropdown in the Display settings. Not about
> any transition.

I understood that. I was asking if "1024x768" -> "1280x768" was in the wrong direction for example.

> The current order looks semi-random to me. The horizontal res is the first
> value, so ordering by it would look far more natural.

Right, got it.
Comment 4 Olaf van der Spek 2012-03-06 13:42:32 UTC
Ah, no, descending is fine.

Before (now):
1920 x 1200
1920 x 1080
1600 x 1200
1680 x 1050
1400 x 1050
1280 x 1024
1440 x 900
1280 x 960
1366 x 768
1360 x 768

After (requested):

1920 x 1200
1920 x 1080
1680 x 1050
1600 x 1200
1440 x 900
1400 x 1050
1366 x 768
1360 x 768
1280 x 1024
1280 x 960
Comment 5 Bastien Nocera 2012-03-07 16:15:01 UTC
Created attachment 209182 [details] [review]
display: Sort resolutions by width first
Comment 6 Olaf van der Spek 2012-03-07 16:23:02 UTC
Review of attachment 209182 [details] [review]:

> SORT_COL, width * 10000 + height

10000 might not be large enough to separate width and height if for example Eyefinity is used
Comment 7 Bastien Nocera 2012-03-07 16:46:07 UTC
(In reply to comment #6)
> Review of attachment 209182 [details] [review]:
> 
> > SORT_COL, width * 10000 + height
> 
> 10000 might not be large enough to separate width and height if for example
> Eyefinity is used

The day somebody sends me 2 6-display rigs, I'll change the code. I also doubt that the machines that support this width have support for XRandR. In the worst case, I'll fix it in GNOME 10 :)
Comment 8 Matthias Clasen 2012-03-07 23:28:18 UTC
With the patch, I get 

1366 x 768
1024 x 768
 800 x 600

So it seems to work fine.
Comment 9 Bastien Nocera 2012-03-08 09:47:27 UTC
Thanks for testing!

Attachment 209182 [details] pushed as 048a9bc - display: Sort resolutions by width first