After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671453 - Improve the configure check for XInput 2.2
Improve the configure check for XInput 2.2
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-03-06 11:15 UTC by Murray Cumming
Modified: 2012-03-06 12:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-configure.ac-Improve-the-checks-for-XInput-2.2.patch (1.27 KB, patch)
2012-03-06 11:15 UTC, Murray Cumming 		none Details | Review
configure.ac: Improve the checks for XInput 2.2 (1.90 KB, patch)
2012-03-06 12:45 UTC, Matthias Clasen 		committed Details | Review

Description Murray Cumming 2012-03-06 11:15:03 UTC 
Created attachment 209063 [details] [review]
0001-configure.ac-Improve-the-checks-for-XInput-2.2.patch

From the commit log of the attached patch:

configure.ac: Improve the checks for XInput 2.2
    
    Check for the XIScrollClassInfo struct in addition to the existing
    check for XIAllowTouchEvents() because Ubuntu Oneiric seems to
    have an incomplete backport which has one but not the other.


This fixes this build problem for me:

gdkdevicemanager-xi2.c: In function 'translate_device_classes':
 gdkdevicemanager-xi2.c:239:14: error: 'XIScrollClass' undeclared (first use in this function)
Comment 1 Matthias Clasen 2012-03-06 12:45:53 UTC 
The following fix has been pushed:
4b05f41 configure.ac: Improve the checks for XInput 2.2
Comment 2 Matthias Clasen 2012-03-06 12:45:56 UTC 
Created attachment 209081 [details] [review]
configure.ac: Improve the checks for XInput 2.2

Check for the XIScrollClassInfo struct in addition to the existing
check for XIAllowTouchEvents() because Ubuntu Oneiric seems to
have an incomplete backport which has one but not the other.

Based on a patch by Murray Cumming,