After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671358 - [info] empty combo entries in the "Other Media" type combo
[info] empty combo entries in the "Other Media" type combo
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Other Preferences
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-05 12:51 UTC by Sebastien Bacher
Modified: 2012-06-14 17:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
that "fixes" the issue for me (968 bytes, patch)
2012-03-05 12:54 UTC, Sebastien Bacher 		committed Details | Review

Description Sebastien Bacher 2012-03-05 12:51:47 UTC 
Using g-c-c 3.3.90 on Ubuntu precise:

* gnome-control-center info
* selected removable media on the left bar
* click on "other medias..." on the right

the dialog which is displayed has 2 combos, the first one has some empty lines
Comment 1 Sebastien Bacher 2012-03-05 12:54:42 UTC 
Created attachment 208997 [details] [review]
that "fixes" the issue for me

The issue is with this code

    for (n = 0; n < G_N_ELEMENTS (other_defs); n++) {
       if (strcmp (content_type, other_defs[n].content_type) == 0) {
         const gchar *s = other_defs[n].description;
         if (s == _(s))
           description = g_content_type_get_description (content_type);
         else
           description = g_strdup (_(s));

It iterates over the known content types, which here include "x-content/win32-software" and "x-content/software" which are not in the other_defs(] list

Not sure if adding them to the list is correct, it "fixes" the issue but having to play catchup on existing mimetypes to avoid empty entries in the combo seems wrong
Comment 2 Bastien Nocera 2012-03-05 14:17:46 UTC 
And the problem is worked-around in this commit.

commit 7e5c60a81822a448087cf3d61f50ae4ca2b63a80
Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Mar 5 14:15:16 2012 +0000

    info: Avoid empty entries in "Other types" dialogue
    
    https://bugzilla.gnome.org/show_bug.cgi?id=671358