GNOME Bugzilla – Bug 670942
Shared template materials for multiple sink objects
Last modified: 2021-05-25 17:32:42 UTC
Created attachment 208549 [details] [review] Use shared template materials for multiple sink objects When a lot of ClutterGstVideoSink objects are used, cogl warning message is printed like following: Over 50 separate fragment shaders have been generated which is very unusual, so something is probably wrong! and, system performance is degraded. Using the shared template material for the same format prevents me from this situation. So, I created a ugly patch for this problem. Could you review and apply it to clutter-gst, or is there another solution?
Just rebased your patch on top of master. I see something weird in the clutter_gst_hw_init() function though. You're not using a static variable for that material, but you do not unref the created material anymore. I might be wrong, but I think there is a bug there. Otherwise it's working well.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/clutter-gst/-/issues/ Thank you for your understanding and your help.