After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670823 - pyatspi configure always enable tests
pyatspi configure always enable tests
Status: RESOLVED FIXED
Product: pyatspi2
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Li Yuan
pyatspi2 maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-02-26 09:47 UTC by Pacho Ramos
Modified: 2015-02-27 16:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
1.patch (474 bytes, patch)
2012-02-26 09:47 UTC, Pacho Ramos 		accepted-commit_now Details | Review

Description Pacho Ramos 2012-02-26 09:47:20 UTC 
Created attachment 208437 [details] [review]
1.patch

As reported downstream at:
https://bugs.gentoo.org/show_bug.cgi?id=401261

Looks like tests are always enabled

checking pkg-config is at least version 0.9.0... yes
checking whether tests are enabled... yes

Attached patch by gokturk fixes this
Comment 1 André Klapper 2012-02-26 10:45:18 UTC 
[Resetting QA Contact to newly introduced "at-spi-maint@gnome.bugs". 
Reason: So far it was impossible to watch changes in at-spi bug reports without following all the specific persons (Li Yuan, Bill Haneman, Jeff Wai, ...) and also their activity outside of at-spi reports.

IMPORTANT: Anyone interested in following all bug activity (including all maintainers) must watch the "at-spi-maint@gnome.bugs" dummy user by adding it to the 'Users to watch' list under Preferences->Email preferences. This is also the default procedure nowadays in GNOME when setting up new products.]
Comment 2 Mike Gorse 2012-03-06 00:38:44 UTC 
Comment on attachment 208437 [details] [review]
1.patch

I'm sorry--I forgot about this bug until now. Anyway, the patch looks good.
Do you have commit access, or would you like me to commit it?



>--- configure.ac.orig	2012-02-11 21:00:51.650000004 -0500
>+++ configure.ac	2012-02-11 21:01:02.680000006 -0500
>@@ -25,7 +25,7 @@
> AC_MSG_CHECKING([whether tests are enabled])
> AC_ARG_ENABLE(tests,
>               [AS_HELP_STRING([--enable-tests], [Build with testing enabled])],
>-              enable_tests=yes,
>+              enable_tests=$enableval,
>               enable_tests=no)
> AC_MSG_RESULT($enable_tests)
> AM_CONDITIONAL(ENABLE_TESTING, test x$enable_tests == xyes)
Comment 3 Pacho Ramos 2012-03-06 08:51:11 UTC 
I don't have, then, would be better if you could commit it :)
Comment 4 Mike Gorse 2012-03-19 18:52:37 UTC 
Committed: cd1b09

Thanks for the patch.
Comment 5 André Klapper 2015-02-27 16:41:14 UTC 
[Moving at-spi/pyatspi2 bugs to separate product. See bug 740075]