After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670743 - Make GtkLabel respect css background
Make GtkLabel respect css background
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkLabel
unspecified
Other Linux
: Normal normal
: 3.6
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-02-24 13:36 UTC by Paolo Borelli
Modified: 2012-04-30 19:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.09 KB, patch)
2012-02-24 13:36 UTC, Paolo Borelli 		committed Details | Review
reftest patch (1.19 KB, patch)
2012-02-24 13:38 UTC, Paolo Borelli 		none Details | Review
patch (5.71 KB, patch)
2012-04-30 19:47 UTC, Paolo Borelli 		none Details | Review

Description Paolo Borelli 2012-02-24 13:36:00 UTC 
Too late for 3.4? In theory it should be harmless since the default background is transparent. In practice for adwaita I simply added

GtkLabel, GtkLabel:insensitive {
    background-color: transparent;
}
Comment 1 Paolo Borelli 2012-02-24 13:36:26 UTC 
Created attachment 208347 [details] [review]
patch
Comment 2 Paolo Borelli 2012-02-24 13:38:14 UTC 
Created attachment 208348 [details] [review]
reftest patch

Fix a reftest I recently committed to reflect the label changes. Probably other reftest need updating, but right now many of them fail for me with or without this patch...
Comment 3 Cosimo Cecchi 2012-02-27 19:17:52 UTC 
We talked about this with Paolo on IRC, but it's probably too late in the 3.4 cycle for such a change (since it requires changes in the themes).
Anyway if we make GtkLabel render a background, it should also render a frame, which is not done in this patch.
Comment 4 Matthias Clasen 2012-04-28 06:42:49 UTC 
Cosimo, should we get this landed now ?
Comment 5 Cosimo Cecchi 2012-04-30 17:14:44 UTC 
Pushed the patch to master (with the frame addition too).
Comment 6 Paolo Borelli 2012-04-30 19:46:25 UTC 
(reopening and slightly hijaking this bug)

1) patch in comment 2 should still be applied

2) the reftest still does not pass at the moment, but this is not related to the label background patch, it is due to the fact that infobar draws a border but does not request size for it

Patch attached
Comment 7 Paolo Borelli 2012-04-30 19:47:00 UTC 
Created attachment 213133 [details] [review]
patch
Comment 8 Paolo Borelli 2012-04-30 19:55:13 UTC 
<cosimoc_afk> pbor_, pusha tutto!


Pushed to master