GNOME Bugzilla – Bug 670443
clicking twice on "New game" starts a game without asking which size it should pick
Last modified: 2012-07-05 21:32:33 UTC
When you click once on the "New game" button, you're presented a start widget with all sizes available. If you click a second time, a new game starts. I'm unable to define if it is a bug or a feature. if it is the former I guess it should be fixed, for the latter, I do think there something missing in the flow.
*** Bug 670444 has been marked as a duplicate of this bug. ***
It was intentionally added in bug 664974, but I agree it's a bit odd. I think it would be better to have a menu item for "Restart" (not sure of the name) which would start a new game with the same board size.
Yes, it was intentional. It made sense to me, but seeing as both of you don't like it, I suppose it's less intuitive than I thought. I'll try and find the time to write a patch for this.
Created attachment 209374 [details] [review] [PATCH] Modify GnoMine's field size repeat behavior. This is my proposed solution.
Review of attachment 209374 [details] [review]: Looks great and works well, thanks Mike. I think this needs a freeze exception [1] but I don't have the time to get this done before final freeze. If anyone can get this (or can determine this is not covered by the UI freeze) please feel free to commit this patch. [1] http://live.gnome.org/ReleasePlanning/Freezes
Created attachment 209798 [details] [review] Newer patch, adds a menu option to repeat the last field size Ugh, I was just about to comment on this, and looking back on the patch I uploaded, I realized I had absent-mindedly forgotten to stage my changes before committing. Well, here's the patch I intended to submit, which also includes a menu option to restart the most recent game. I realize this doesn't help with the feature freeze situation (especially because it includes new strings, which would make translation difficult at this point in time). If, by any chance, this can get committed before feature freeze, it might be better to commit the last patch (which doesn't include the new menu option), and then commit the other 1/2 of this (the menu option) after branching. If that does not happen, then this is the patch that I think should get committed post-branching.
Created attachment 218110 [details] [review] Same as last patch, but rebased against master. My last patch bitrotted enough so it wouldn't apply cleanly against master. I regenerated it, so it does apply now.
Review of attachment 218110 [details] [review]: Hi, thanks for that. I've committed this with a few changes: - Add a shortcut key (ctrl-R) - Shorten name to "Replay Size" - Only show when already in a game - Fixed some whitespace errors