GNOME Bugzilla – Bug 670376
gdl uses deprecated GRelation API
Last modified: 2012-02-26 11:36:58 UTC
The GRelation API is deprecated in glib >= 2.26,[1] and should be replaced with something else. This causes issues when gdl is built with G_DISABLE_DEPRECATED defined. [1] http://developer.gnome.org/glib/2.30/glib-Relations-and-Tuples.html
Patches welcome. :)
I'm having a look into it... maybe I can replace the GRelation with a GArray of structs that contain fields for the nick and type.
Created attachment 207971 [details] [review] Patch to replace GRelation with GArray Here's a draft patch that still needs testing. Please could you let me know if I'm working along the right lines?
Review of attachment 207971 [details] [review]: In general this looks good to me and also the coding style is pretty good - thanks! You can use the gdl/test-dock app for testing if this helps. Probably I will have a look myself later. ::: src/libgdl/gdl-dock-object.c @@ -899,3 @@ return; - /* FIXME: i don't know if GRelation is efficient */ Must have been one of the few people who knew that GRelation exists at all...
And of course a git patch (git format-patch) would be preferred...
Hi Johannes, I'm away from home at the moment, and I don't have a good enough network connection available to clone the gdl repo on my laptop. I'll certainly take care of it next week, when I'm back home, and format a proper patch. Some testing by ~suv on the Inkscape team shows that my patch causes a crash when opening/closing multiple docked dialogs.[1] I guess I must have messed something up in the initialisation/value-lookup. [1] https://bugs.launchpad.net/inkscape/+bug/933058
Created attachment 208412 [details] [review] Patch to replace GRelation with GArray Here's an updated git patch that hopefully fixes the issues ~suv spotted with the last version.
Thanks, looks good now!