After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670320 - gst-plugins-good 0.11.1 fails to build due to missing gstsmokedec.h
gst-plugins-good 0.11.1 fails to build due to missing gstsmokedec.h
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.11.x
Other Linux
: Normal normal
: 0.11.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-17 20:25 UTC by Dominique Leuenberger
Modified: 2012-02-18 11:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
No longer reference deprecated header files while building docs. (604 bytes, patch)
2012-02-17 20:25 UTC, Dominique Leuenberger 		committed Details | Review

Description Dominique Leuenberger 2012-02-17 20:25:52 UTC 
Created attachment 207903 [details] [review]
No longer reference deprecated header files while building docs.

Building gst-plugins-good-0.11.1 tarball results in this build error:

make[3]: Leaving directory `/home/abuild/rpmbuild/BUILD/gst-plugins-good-0.11.1/tests'
make[2]: Leaving directory `/home/abuild/rpmbuild/BUILD/gst-plugins-good-0.11.1/tests'
Making all in docs
make[2]: Entering directory `/home/abuild/rpmbuild/BUILD/gst-plugins-good-0.11.1/docs'
Making all in plugins
make[3]: Entering directory `/home/abuild/rpmbuild/BUILD/gst-plugins-good-0.11.1/docs/plugins'
make[3]: *** No rule to make target `../../ext/jpeg/gstsmokedec.h', needed by `scan-build.stamp'.  Stop.
make[3]: Leaving directory `/home/abuild/rpmbuild/BUILD/gst-plugins-good-0.11.1/docs/plugins'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/abuild/rpmbuild/BUILD/gst-plugins-good-0.11.1/docs'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/abuild/rpmbuild/BUILD/gst-plugins-good-0.11.1'
make: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.K6tuQE (%build)


gstsmoedec.h (and also gstsmokeenc.h) are removed from the 'ext/jpeg/Makefile.am' file stating they are deprecated. This change did not make it into docs/plugins/Makefile.am.

The attached patch removes the two file-references there as well.

(The commit marking those headers as deprecated was http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/ext/jpeg/Makefile.am?h=0.11&id=be4f60b0622ac25245830b3d7b601394559d54fe )
Comment 1 Tim-Philipp Müller 2012-02-18 11:42:32 UTC 
Someone didn't run 'make distcheck' it seems :)

Looks like Wim pushed this already:

 commit c2dd44be6cd53dcc9964e80d3e6fc9ba996ed861
 Author: Dominique Leuenberger <dominique-gnomezilla at leuenberger.net>
 Date:   Fri Feb 17 23:54:29 2012 +0100

    No longer reference deprecated header files while building docs.