After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670298 - If denying access to GNOME, GOA displayed a cryptic error message
If denying access to GNOME, GOA displayed a cryptic error message
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-02-17 16:09 UTC by Baptiste Mille-Mathias
Modified: 2012-07-13 08:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Baptiste Mille-Mathias 2012-02-17 16:09:45 UTC 
Should you do the google authentication process but deny acces to GNOME at the end of the process, GOA shoots at you with the following message.

Access Token: Bad Request

it should rather handle this case properly, and providing a message the user denied access and won't be able to use google services inside GNOME applications.
Comment 1 Debarshi Ray 2012-07-12 18:52:17 UTC 
commit ff737758e41069977c6e116a86f24c1168fa3af9
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Thu Jul 12 20:35:18 2012 +0200

    oauthprovider: Don't display an error message if user denied access
    
    If the user deliberately denied access by clicking the appropriate
    HTMLButtonElement or HTMLInputElement in the embedded browser, then
    no error message should be displayed.
    
    Added a is_deny_node pure virtual method to GoaOAuthProvider to let
    the providers indicate those HTML nodes that can be used for denial.
    
    Fixes: https://bugzilla.gnome.org/670298

commit 06079452f0adb93e14b390cc1d4a219b0c59f051
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Thu Jul 12 19:17:21 2012 +0200

    oauth2provider: Don't display an error message if user denied access
    
    If the user deliberately denied access by clicking the appropriate
    HTMLButtonElement or HTMLInputElement in the embedded browser, then
    no error message should be displayed.
    
    Added a is_deny_node pure virtual method to GoaOAuth2Provider to let
    the providers indicate those HTML nodes that can be used for denial.
    
    Fixes: https://bugzilla.gnome.org/670298
Comment 2 Matthias Clasen 2012-07-12 23:37:00 UTC 
Fixed ?!
Comment 3 Debarshi Ray 2012-07-13 08:30:41 UTC 
Yes, thanks for changing the status.