After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670291 - Do not show the titlebar when the window is maximized
Do not show the titlebar when the window is maximized
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other All
: Normal enhancement
: gnome-3-6
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
[fixed-gsettings]
: 676772 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-02-17 15:13 UTC by Frederic Peters
Modified: 2013-01-27 13:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Do not show the titlebar when the window is maximized (865 bytes, patch)
2012-02-17 15:13 UTC, Frederic Peters
none Details | Review

Description Frederic Peters 2012-02-17 15:13:25 UTC
The HIG being written for GNOME 3 notes that primary windows should lose their
titlebar when maximized; there is now a dedicated method in GTK+, this makes
implementing this behaviour in gnome-terminal very easy.

There's still an open question, at the moment it has this behaviour even if
there's no menu bar, this is good in the sense that it adds even more vertical
space to the terminal, this is bad as there's no unmaximizing possible without
getting to the window menu by keyboard shortcut (alt-space).
Comment 1 Frederic Peters 2012-02-17 15:13:27 UTC
Created attachment 207857 [details] [review]
Do not show the titlebar when the window is maximized
Comment 2 Christian Persch 2012-02-17 17:00:04 UTC
Not sure about this. In contrast to most app that just show their name in the titlebar, g-t actually has relevant info in the titlebar.

Also, will this make the titlebar disappear only in the shell, or in fallback mode too?
Comment 3 Frederic Peters 2012-02-17 17:09:27 UTC
True, I didn't think about the title content, as I use tabs and rely on their titles for that information; I can't think of alternatives right now.

With regards to the fallback mode, this works by setting a hint for the window manager (_GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED), so it won't be hidden when using metacity and friends (unless they evolves to handle it).
Comment 4 Alexandre Franke 2012-02-20 08:42:32 UTC
In the GNOME Shell case, couldn't the useful information be moved from the titlebar to the application name in the top bar?
Comment 5 Frederic Peters 2012-03-04 20:05:39 UTC
(In reply to comment #0)
> There's still an open question, at the moment it has this behaviour even if
> there's no menu bar, this is good in the sense that it adds even more vertical
> space to the terminal, this is bad as there's no unmaximizing possible without
> getting to the window menu by keyboard shortcut (alt-space).

FWIW GNOME Shell now allows dragging from the top bar to unmaximize.
Comment 6 Allan Day 2012-03-13 08:53:46 UTC
In general we're only doing this titlebar behaviour for applications that have been designed around it. These applications have a space in the toolbar to show window title information, for example. Also, I'm not sure that this would work with a menubar.
Comment 7 Josh Triplett 2012-03-15 19:31:11 UTC
(In reply to comment #6)
> In general we're only doing this titlebar behaviour for applications that have
> been designed around it. These applications have a space in the toolbar to show
> window title information, for example. Also, I'm not sure that this would work
> with a menubar.

gnome-terminal seems like a good candidate to use an application menu, as well.  That would allow terminal content to use almost the entire screen, apart from the gnome-shell top bar.
Comment 8 Felix Lange 2012-04-10 11:30:26 UTC
Couldn't this be a configuration option (checkbox)?
Comment 9 Christian Persch 2012-04-10 11:41:02 UTC
We generally don't want to add too many options...

IMHO this doesn't make sense. E.g. on 1920x1080, now a common desktop screen size, a terminal using the default font is 239x68, which is way too wide to be useful. Vertical maximisation is useful, but horizontal maximisation is nonsense.
Comment 10 Felix Lange 2012-04-10 12:16:11 UTC
For me, this is a question of aesthetics. When a black background is used and the window is maximized, the white (actually gray) Adwaita titlebar doesn't look good anymore.

Maximizing the window on a widescreen monitor actually does make sense when
using tmux or screen with window splitting.

I should probably use a different terminal emulator if I'm that picky about UI design, but gnome-terminal is working rather well, and has adopted most
GNOME 3 UI decisions.

This issue should probably be put into the caring hands of the UX crowd.
Comment 11 Josh Triplett 2012-04-10 17:50:13 UTC
(In reply to comment #9)
> We generally don't want to add too many options...
> 
> IMHO this doesn't make sense. E.g. on 1920x1080, now a common desktop screen
> size, a terminal using the default font is 239x68, which is way too wide to be
> useful. Vertical maximisation is useful, but horizontal maximisation is
> nonsense.

First of all, as much as I'd love to have 1080p, at the moment many laptops provide resolutions like 1366x768, where maximization makes more sense.  And second, I'd love to have a terminal with that many lines and columns, because I can always vertically split it in vim or screen; multiples of 80 columns (plus a few spare for split separators) work nicely for that.
Comment 12 Josh Triplett 2012-04-10 17:58:00 UTC
(In reply to comment #10)
> For me, this is a question of aesthetics. When a black background is used and
> the window is maximized, the white (actually gray) Adwaita titlebar doesn't
> look good anymore.

Precisely.  I have a black top bar, a white title bar, and then a black terminal.  I'd like to eliminate the title bar, and in the process get 1-2 more terminal lines.

> Maximizing the window on a widescreen monitor actually does make sense when
> using tmux or screen with window splitting.

Or when running programs that can take advantage of all the columns they have.  In the common case of a shell, "ls" will happily take advantage of as many columns as it has.
Comment 13 Christian Persch 2012-05-03 19:07:14 UTC
Fixed on master.
Comment 14 Christian Persch 2012-05-24 19:21:10 UTC
*** Bug 676772 has been marked as a duplicate of this bug. ***
Comment 15 Andreas Kloeckner 2012-11-03 22:15:54 UTC
This is not fixed in gnome-terminal 3.6.1, i.e. the title bar is still shown. I've obtained 3.6.1 from Debian.
Comment 16 Christian Persch 2012-11-03 22:21:31 UTC
Nothing in this bug report suggests that this would be fixed in 3.6.x . Comment 13 specifically says [git] master.