After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670271 - Add introspection support for libspreadsheet.
Add introspection support for libspreadsheet.
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: General
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on: 670161
Blocks: 675698
 
 
Reported: 2012-02-17 10:33 UTC by Jean Bréfort
Modified: 2012-07-11 18:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Makes things at least build. (22.20 KB, patch)
2012-02-17 10:33 UTC, Jean Bréfort
none Details | Review
updated patch (21.06 KB, patch)
2012-06-27 11:40 UTC, Jean Bréfort
none Details | Review
Updated patch with python support (28.30 KB, patch)
2012-07-11 15:39 UTC, Jean Bréfort
none Details | Review

Description Jean Bréfort 2012-02-17 10:33:07 UTC
Created attachment 207843 [details] [review]
Makes things at least build.

Needs some changes, see attached patch.
Comment 1 Morten Welinder 2012-02-19 01:44:50 UTC
The GNMUndo -> GnmUndo part can go in right away.

The nested-struct thing bothers me.  Do we have a bugzilla entry for
gir on that?
Comment 2 Jean Bréfort 2012-02-19 20:30:48 UTC
Looks like #659955.
Comment 3 Jean Bréfort 2012-06-27 11:40:19 UTC
Created attachment 217388 [details] [review]
updated patch
Comment 4 Jean Bréfort 2012-07-11 15:39:54 UTC
Created attachment 218565 [details] [review]
Updated patch with python support

With this patch, python seems to work again. Just we still need to deal with the nested structures bug, and when running make with introspection enabled, we get some criticals while running g-ir-scanner:

(process:18244): GLib-GObject-CRITICAL **: g_object_set_data_full: assertion `G_IS_OBJECT (object)' failed

(process:18244): GLib-CRITICAL **: g_hash_table_lookup: assertion `hash_table != NULL' failed

(process:18244): GLib-CRITICAL **: g_hash_table_lookup: assertion `hash_table != NULL' failed

(process:18244): GLib-CRITICAL **: g_hash_table_lookup: assertion `hash_table != NULL' failed

(process:18244): GLib-CRITICAL **: g_hash_table_insert_internal: assertion `hash_table != NULL' failed

(process:18244): GLib-CRITICAL **: g_hash_table_insert_internal: assertion `hash_table != NULL' failed

** (process:18244): CRITICAL **: go_conf_add_monitor: assertion `node || key' failed

** (process:18244): CRITICAL **: go_conf_get_node: assertion `parent || key' failed
g-ir-scanner: Gnm: warning: 945 warnings suppressed (use --warn-all to see them)
  GEN    Gnm-1.12.typelib

The 945 warnings are about returned structs that should be made boxed types and the like.
Morten, may I commit?
Comment 5 Jean Bréfort 2012-07-11 18:13:19 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.