After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670236 - segfault on defining shortcuts
segfault on defining shortcuts
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
git master
Other Linux
: Normal major
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-16 17:37 UTC by Tomas Bzatek
Modified: 2012-02-20 10:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (960 bytes, patch)
2012-02-16 17:37 UTC, Tomas Bzatek 		committed Details | Review

Description Tomas Bzatek 2012-02-16 17:37:19 UTC 
Created attachment 207797 [details] [review]
proposed patch

There's a segfault when trying to set a shortcut for various items - mostly those which GSettings type is "as", such as window keybindings.

I don't know if there's a possibility to define multiple shortcuts for each action, I haven't touched existing code.

The attached patch fixes a problem with replacing shortcut in empty strv list, thus effectively replacing the end NULL pointer. So let's free the empty array and allocate space for one item which is to be replaced.
Comment 1 Bastien Nocera 2012-02-16 17:46:30 UTC 
Review of attachment 207797 [details] [review]:

Looks good. Try to get Florian to look at it too.