After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670201 - import dialog improvements
import dialog improvements
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.33.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks: 652669
 
 
Reported: 2012-02-16 11:24 UTC by Guillaume Desmottes
Modified: 2012-02-16 13:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove useless include (769 bytes, patch)
2012-02-16 11:26 UTC, Guillaume Desmottes 		committed Details | Review
factor out display_import_dialog() (1.23 KB, patch)
2012-02-16 11:26 UTC, Guillaume Desmottes 		committed Details | Review
Pass EmpathyConnectionManagers to the import widget (9.88 KB, patch)
2012-02-16 11:26 UTC, Guillaume Desmottes 		committed Details | Review
import-dialog: expand and fill the import widget (951 bytes, patch)
2012-02-16 11:26 UTC, Guillaume Desmottes 		committed Details | Review
import-dialog: set a verb on the 'Ok' button (957 bytes, patch)
2012-02-16 11:26 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-02-16 11:24:30 UTC 
As part of my work on bug #652669 I did some improvements on the import dialog.
Comment 1 Guillaume Desmottes 2012-02-16 11:26:02 UTC 
Created attachment 207745 [details] [review]
remove useless include
Comment 2 Guillaume Desmottes 2012-02-16 11:26:05 UTC 
Created attachment 207746 [details] [review]
factor out display_import_dialog()
Comment 3 Guillaume Desmottes 2012-02-16 11:26:08 UTC 
Created attachment 207747 [details] [review]
Pass EmpathyConnectionManagers to the import widget

The widget doesn't have to prepare EmpathyConnectionManagers itself any more
and so can populate its treeview right away. By doing so it will request a
more decent size and so the dialog will actually display the accounts which
can be imported without forcing user to resize it.
Comment 4 Guillaume Desmottes 2012-02-16 11:26:11 UTC 
Created attachment 207748 [details] [review]
import-dialog: expand and fill the import widget
Comment 5 Guillaume Desmottes 2012-02-16 11:26:14 UTC 
Created attachment 207749 [details] [review]
import-dialog: set a verb on the 'Ok' button
Comment 6 Will Thompson 2012-02-16 11:46:11 UTC 
Review of attachment 207745 [details] [review]:

Sure, why not.
Comment 7 Will Thompson 2012-02-16 11:47:27 UTC 
Review of attachment 207746 [details] [review]:

::: src/empathy-accounts-dialog.c
@@ +2024,3 @@
+    EmpathyAccountsDialog *dialog)
+{
+

I guess this doesn't leak import_dialog any more than it used to…
Comment 8 Will Thompson 2012-02-16 11:49:46 UTC 
Review of attachment 207747 [details] [review]:

This looks fine and I approve of this kind of improvement
Comment 9 Will Thompson 2012-02-16 11:50:21 UTC 
Review of attachment 207748 [details] [review]:

Looks fine.
Comment 10 Will Thompson 2012-02-16 11:50:43 UTC 
Review of attachment 207749 [details] [review]:

Aye.
Comment 11 Guillaume Desmottes 2012-02-16 11:58:04 UTC 
Review of attachment 207746 [details] [review]:

::: src/empathy-accounts-dialog.c
@@ +2024,3 @@
+    EmpathyAccountsDialog *dialog)
+{
+

Nah that's fine, the dialog is destroying itself once it's done. That's a bit weird I agree, but that's not so uncommon for this kind of dialog.
Comment 12 Guillaume Desmottes 2012-02-16 13:09:39 UTC 
Attachment 207745 [details] pushed as 4fe19e7 - remove useless include
Attachment 207746 [details] pushed as 540ebef - factor out display_import_dialog()
Attachment 207747 [details] pushed as 9e91ccd - Pass EmpathyConnectionManagers to the import widget
Attachment 207748 [details] pushed as bb7c70e - import-dialog: expand and fill the import widget
Attachment 207749 [details] pushed as 8586e87 - import-dialog: set a verb on the 'Ok' button