After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670107 - power: layout tweaks to new power panel UI
power: layout tweaks to new power panel UI
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Power
unspecified
Other All
: Normal normal
: ---
Assigned To: Richard Hughes
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-14 23:10 UTC by Cosimo Cecchi
Modified: 2012-02-15 16:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
power: set dim-label style classes on left labels (1.94 KB, patch)
2012-02-14 23:10 UTC, Cosimo Cecchi 		committed Details | Review
power: port main box to GtkGrid (14.36 KB, patch)
2012-02-14 23:10 UTC, Cosimo Cecchi 		committed Details | Review
power: hide "When power is critical" elements when there's no batteries (1.59 KB, patch)
2012-02-14 23:10 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-02-14 23:10:11 UTC 
Here are some patches that fix some bugs I spotted while trying out the new Power panel design that landed earlier today.
Comment 1 Cosimo Cecchi 2012-02-14 23:10:13 UTC 
Created attachment 207597 [details] [review]
power: set dim-label style classes on left labels

To be consistent with other panels.
Comment 2 Cosimo Cecchi 2012-02-14 23:10:15 UTC 
Created attachment 207598 [details] [review]
power: port main box to GtkGrid

Instead of a box of boxes; this way we can easily align labels without
an additional GtkSizeGroup using halign.
Comment 3 Cosimo Cecchi 2012-02-14 23:10:17 UTC 
Created attachment 207599 [details] [review]
power: hide "When power is critical" elements when there's no batteries

As for the mockups
Comment 4 Richard Hughes 2012-02-15 10:37:40 UTC 
Can you push these to master please. Thanks dude.

Richard.
Comment 5 Richard Hughes 2012-02-15 10:38:13 UTC 
(you might need to revert the last commit I made today before I saw this bug, sorry).
Comment 6 Cosimo Cecchi 2012-02-15 16:14:10 UTC 
Attachment 207597 [details] pushed as 4093f9e - power: set dim-label style classes on left labels
Attachment 207598 [details] pushed as 02e5cb7 - power: port main box to GtkGrid
Attachment 207599 [details] pushed as 240faca - power: hide "When power is critical" elements when there's no batteries

Pushed these to master.