After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670098 - Change 'undo' and 'clear' buttons to use symbolic icons
Change 'undo' and 'clear' buttons to use symbolic icons
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-14 20:45 UTC by Rui Matos
Modified: 2012-10-18 20:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Change 'undo' and 'clear' buttons to use symbolic icons (3.73 KB, patch)
2012-02-14 20:45 UTC, Rui Matos
committed Details | Review

Description Rui Matos 2012-02-14 20:45:30 UTC
This way they don't stand out as much and the whole window looks more
seamless.
Comment 1 Rui Matos 2012-02-14 20:45:32 UTC
Created attachment 207589 [details] [review]
Change 'undo' and 'clear' buttons to use symbolic icons
Comment 2 Robert Ancell 2012-02-15 22:33:02 UTC
Review of attachment 207589 [details] [review]:

Thanks Rui, looks much better!
Comment 3 Robert Ancell 2012-02-15 22:33:48 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 4 Patrick Welche 2012-10-18 17:50:55 UTC
It doesn't look much better if you don't have those particular icons installed, and when you see two "missing icon" icons, you can't tell which is undo, nor which is clear - in that case text rather than an icon is better.

Can this please be reverted, sticking by default to the icons which are guaranteed to exist on any system which has gtk?

Isn't this something for theming?
Comment 5 Robert Ancell 2012-10-18 20:25:09 UTC
Please don't re-open this bug. If you have issues displaying the icons then open a bug with your distribution that is not correctly depending on them.