After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670048 - Display a message if no contact is displayed because they are offline
Display a message if no contact is displayed because they are offline
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Contact List
2.33.x
Other Linux
: Normal enhancement
: 3.8
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks: 658858
 
 
Reported: 2012-02-14 09:56 UTC by Guillaume Desmottes
Modified: 2012-12-26 10:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
roster-window: display a messagen if no online contacts are displayed (2.48 KB, patch)
2012-04-20 09:16 UTC, Guillaume Desmottes
none Details | Review
display_page_message(): use a flag rather than booleans (3.52 KB, patch)
2012-04-20 09:16 UTC, Guillaume Desmottes
none Details | Review
Display a button to show offline contacts with the message (5.25 KB, patch)
2012-04-20 09:16 UTC, Guillaume Desmottes
none Details | Review
roster-window: display a specific message if there is no offline contact either (1.27 KB, patch)
2012-12-26 10:16 UTC, Guillaume Desmottes
none Details | Review
roster-window: add a 'Show offline button" when relevant (5.48 KB, patch)
2012-12-26 10:16 UTC, Guillaume Desmottes
none Details | Review
roster-window: add 'Add Contact...' button when relevant (4.82 KB, patch)
2012-12-26 10:16 UTC, Guillaume Desmottes
none Details | Review

Description Guillaume Desmottes 2012-02-14 09:56:42 UTC
In bug #656097 we added more informative message when no contact was displayed. We could extend this by displaying a message when all contacts are offline and offline contacts are not displayed. Ideally we should have a button to display those.

Once we have this we'll consider not displaying offline contacts by default: bug #658858
Comment 1 Guillaume Desmottes 2012-04-20 09:16:26 UTC
Created attachment 212406 [details] [review]
roster-window: display a messagen if no online contacts are displayed
Comment 2 Guillaume Desmottes 2012-04-20 09:16:28 UTC
Created attachment 212407 [details] [review]
display_page_message(): use a flag rather than booleans

It's more scalable.
Comment 3 Guillaume Desmottes 2012-04-20 09:16:31 UTC
Created attachment 212408 [details] [review]
Display a button to show offline contacts with the message
Comment 4 Guillaume Desmottes 2012-12-26 10:15:44 UTC
Most of those patches have been merged already. Re-implementing the new bits.
Comment 5 Guillaume Desmottes 2012-12-26 10:16:19 UTC
Created attachment 232230 [details] [review]
roster-window: display a specific message if there is no offline contact either

Displaying "No online contacts" while we are actually displaying all the
contacts is miss leading.
Comment 6 Guillaume Desmottes 2012-12-26 10:16:21 UTC
Created attachment 232231 [details] [review]
roster-window: add a 'Show offline button" when relevant
Comment 7 Guillaume Desmottes 2012-12-26 10:16:24 UTC
Created attachment 232232 [details] [review]
roster-window: add 'Add Contact...' button when relevant
Comment 8 Xavier Claessens 2012-12-26 10:28:29 UTC
+1
Comment 9 Guillaume Desmottes 2012-12-26 10:31:31 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.