After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669961 - Location of "Left-handed" and "Right-handed" are switched, logically
Location of "Left-handed" and "Right-handed" are switched, logically
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Mouse
3.3.x
Other Linux
: Normal minor
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-13 03:48 UTC by Robert Roth
Modified: 2012-08-28 11:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
switch left/right radios according text direction (2.23 KB, patch)
2012-08-23 12:38 UTC, Ondrej Holy
needs-work Details | Review
switch left/right radios according text direction (1.75 KB, patch)
2012-08-23 14:05 UTC, Ondrej Holy
committed Details | Review
bad radio spacing fix (1.11 KB, patch)
2012-08-23 14:52 UTC, Ondrej Holy
committed Details | Review

Description Robert Roth 2012-02-13 03:48:56 UTC
Reported by kroq-gar78 at https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/885947

On the control panel where the "Mouse and Touchpad" settings are, the "Right-handed" option is on the left side of the "Left-handed" option, which is on the right of the "Right-handed" option. This seems slightly strange in my opinion, as one would think that the left-handed option is on the left side, opposed to where it currently is.
Comment 1 Ondrej Holy 2012-08-23 07:46:30 UTC
I think the bug is fixed along with: 

https://bugzilla.gnome.org/show_bug.cgi?id=677206
Comment 2 Bastien Nocera 2012-08-23 09:01:41 UTC
It's not fixed for Right-To-Left locales. Try:
LC_ALL=ar_EG gnome-control-center mouse
Comment 3 Ondrej Holy 2012-08-23 12:38:28 UTC
Created attachment 222215 [details] [review]
switch left/right radios according text direction
Comment 4 Bastien Nocera 2012-08-23 12:49:52 UTC
Review of attachment 222215 [details] [review]:

Use gtk_widget_set_direction() on the box that contains the radio buttons, and it won't swap around in RTL languages.
Comment 5 Ondrej Holy 2012-08-23 14:05:50 UTC
Created attachment 222230 [details] [review]
switch left/right radios according text direction

Thanks, I have no idea about gtk_widget_set_direction(). There is weird spacing between radios currently and I don't know how to fix it to be on correct side.
Comment 6 Bastien Nocera 2012-08-23 14:25:39 UTC
Review of attachment 222230 [details] [review]:

Looks good.
Comment 7 Bastien Nocera 2012-08-23 14:26:23 UTC
(In reply to comment #5)
> Created an attachment (id=222230) [details] [review]
> switch left/right radios according text direction
> 
> Thanks, I have no idea about gtk_widget_set_direction(). There is weird spacing
> between radios currently and I don't know how to fix it to be on correct side.

Want to file a separate bug about it? I'm not sure what you're talking about though...
Comment 8 Ondrej Holy 2012-08-23 14:52:00 UTC
Created attachment 222233 [details] [review]
bad radio spacing fix
Comment 9 Bastien Nocera 2012-08-23 14:54:23 UTC
Review of attachment 222233 [details] [review]:

Fine by me.