After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669951 - extensions: resurrect the Tools menu as Extensions
extensions: resurrect the Tools menu as Extensions
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-13 00:14 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2012-02-27 12:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ephy-bookmarks-ui: fix typo in activate_bookmarks_menu (1.09 KB, patch)
2012-02-13 00:14 UTC, Diego Escalante Urrelo (not reading bugmail) 		none Details | Review
ephy-window: add a Extensions menu (1.46 KB, patch)
2012-02-13 00:14 UTC, Diego Escalante Urrelo (not reading bugmail) 		none Details | Review
ephy-window: add a Extensions menu (1.38 KB, patch)
2012-02-24 18:47 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2012-02-13 00:14:05 UTC 
To reenable the extensions manager UI and menu items installed by
extensions.

A 3.3.5 ephy extensions release will follow.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2012-02-13 00:14:07 UTC 
Created attachment 207413 [details] [review]
ephy-bookmarks-ui: fix typo in activate_bookmarks_menu
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2012-02-13 00:14:09 UTC 
Created attachment 207414 [details] [review]
ephy-window: add a Extensions menu

Together with epiphany-extensions-3.3.5 this makes the extensions
manager visible again, and also all the extensions menu items.
Comment 3 Xan Lopez 2012-02-24 11:21:15 UTC 
(In reply to comment #1)
> Created an attachment (id=207413) [details] [review]
> ephy-bookmarks-ui: fix typo in activate_bookmarks_menu

What does this have to do with Extensions?
Comment 4 Xan Lopez 2012-02-24 11:22:11 UTC 
(In reply to comment #2)
> Created an attachment (id=207414) [details] [review]
> ephy-window: add a Extensions menu
> 
> Together with epiphany-extensions-3.3.5 this makes the extensions
> manager visible again, and also all the extensions menu items.

So this will be visible and empty by default?
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2012-02-24 18:47:53 UTC 
Created attachment 208372 [details] [review]
ephy-window: add a Extensions menu

Together with epiphany-extensions-3.3.90 this makes the extensions
manager visible again, and also all the extensions menu items.

=

Indeed, the menu only appears when there are extensions available.
Otherwise it is not present.

Nitpick: should it be internally called Tools, or Extensions?
Comment 6 Xan Lopez 2012-02-24 19:55:33 UTC 
Review of attachment 208372 [details] [review]:

OK.
Comment 7 Diego Escalante Urrelo (not reading bugmail) 2012-02-25 20:12:00 UTC 
Attachment 208372 [details] pushed as 374e31f - ephy-window: add a Extensions menu
Comment 8 Julien Olivier 2012-02-27 12:33:50 UTC 
Now that Epiphany has an application menu (the one visible in gnome-shell's top bar) and a window menu (the one next to the address widget), wouldn't it be more logical to have the extensions menu inside the application menu (rather than inside the window menu)? After all, the extensions are shared by each window of the app, aren't they?